After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315895 - gst_pad_query_convert src_val check
gst_pad_query_convert src_val check
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.9.3
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-10 09:38 UTC by Alessandro Decina
Modified: 2005-10-01 17:11 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
patch (523 bytes, patch)
2005-09-10 09:53 UTC, Alessandro Decina 		committed Details | Review

Description Alessandro Decina 2005-09-10 09:38:13 UTC 
gst_pad_query_convert doesn't check for src_val >= 0. With srcval < 0 the
gst_query_new_convert call in the body fails returning NULL. That makes
gst_pad_query (pad, query) with query = NULL print this:

(process:22871): GStreamer-CRITICAL **: gst_pad_query: assertion `GST_IS_QUERY
(query)' failed

also it ends up unreffing a null pointer.
Comment 1 Alessandro Decina 2005-09-10 09:53:39 UTC 
Created attachment 52047 [details] [review]
patch
Comment 2 Brent Smith (smitten) 2005-09-10 20:07:17 UTC 
Marking NEW and upping priority due to the patch, and null pointer dereference.
Comment 3 Tim-Philipp Müller 2005-10-01 17:11:45 UTC 
2005-10-01  Alessandro Decina  <alessandro at nnva dot org>

        Reviewed by: Tim-Philipp Muller  <tim at centricular dot net>

        * gst/gstutils.c: (gst_pad_query_convert):
          Add assertion that makes sure src_val is >=0, just like
          gst_query_new_convert() has. (#315895)

Cheers
 -Tim