After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315877 - remove cdda from default-modules.conf
remove cdda from default-modules.conf
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Module: (other)
2.12.x
Other Linux
: Normal normal
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
: 317707 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-09-10 00:50 UTC by Ed Catmur
Modified: 2006-06-11 19:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
Proposed patch (2.21 KB, patch)
2005-09-13 19:30 UTC, Christian Neumair
none Details | Review

Description Ed Catmur 2005-09-10 00:50:36 UTC
(gnome-panel:23719): libgnomevfs-WARNING **: Cannot load module
`/usr/lib/gnome-vfs-2.0/modules/libcdda.so'
(/usr/lib/gnome-vfs-2.0/modules/libcdda.so: cannot open shared object file: No
such file or directory)

(gnome-panel:23719): libgnomevfs-WARNING **: Cannot load module
`/usr/lib/gnome-vfs-2.0/modules/libcdda.so'
(/usr/lib/gnome-vfs-2.0/modules/libcdda.so: cannot open shared object file: No
such file or directory)

(gnome-panel:23719): libgnomevfs-WARNING **: Cannot load module
`/usr/lib/gnome-vfs-2.0/modules/libcdda.so'
(/usr/lib/gnome-vfs-2.0/modules/libcdda.so: cannot open shared object file: No
such file or directory)

Reason: default-modules.conf has "cdda: cdda".

Regardless of whether the cdda module is built, this should not be in
default-modules.conf, because if cdda is built cdda-module.conf will be installed.
Comment 1 Brent Smith (smitten) 2005-09-11 04:04:57 UTC
I can confirm that both files exist in /opt/gnome2/etc/gnome-vfs-2.0/ when built
with jhbuild

of course, I have the module installed so I don't get the error, but I'm
going to mark it NEW anyway.
Comment 2 Federico Mena Quintero 2005-09-13 18:44:21 UTC
Also, gnome-vfs-hal-mounts.c is generating activation URIs with "cdda://".  It
shouldn't do that if the CDDA module is not enabled.  I'll raise the severity a
bit because Nautilus ends up popping up "I can't mount CDDA stuff" dialogs.
Comment 3 Christian Neumair 2005-09-13 19:30:09 UTC
Created attachment 52181 [details] [review]
Proposed patch

This patch fixes the HAL problem Federico pointed out and removes the CDDA
entry from default-modules.conf.
Comment 4 Federico Mena Quintero 2005-09-15 14:19:59 UTC
Manny's patch for gnome-vfs-hal-mounts.c looks correct.

Shouldn't default-modules.conf be generated according to whether cdda is
enabled?  I.e. have a default-modules.conf.in and generate the final file
depending on the configuration?

Isn't this the case as well for other optional modules?
Comment 5 Stanislav Brabec 2005-09-15 14:24:38 UTC
Please note that nautilus still requires cdda://, even if it is disabled.
How to reproduce:

* Insert audio cd
* Right click on Icon on desktop
* Choose "Open" or "Browse Folder"

Reference: https://bugzilla.novell.com/show_bug.cgi?id=116472
Comment 6 Christian Neumair 2005-09-15 14:38:13 UTC
Stanislav: That's exactly what this bug report is all about :).

Federico: I initially also thought that it would be a good idea to generate
default-modules.conf, based on the build flags. However, we already seem to ship
separate configuration files for optional modules, including CDDA (cf.
modules/cdda-module.conf). cdda-module.conf was added without removing
references to cdda from default-modules.conf, which poses a bug.
Comment 7 Alexander Larsson 2005-09-20 08:19:22 UTC
We're not really interested in the cdda module. Its a useless piece of shit.

However, we have added cdda: uri handlers that launch the cd player so that
clicking on an audio cd plays it. At least thats how its supposed to work, and
worked at least once upon a time.

cdda should be removed from default-modules.conf though.
Comment 8 Federico Mena Quintero 2005-09-20 14:53:53 UTC
Hmm, interesting.  So gnome-vfs-hal-mounts.c should still generate cdda:// URIs?
 I wonder why nothing gets invoked when I double-click on the CD icon in the
desktop (rather, I get an unfriendly "x-nautilus-desktop://... is not a valid
location" dialog).  Where is the URI handler for cdda defined?
Comment 9 Christian Neumair 2005-09-20 15:31:16 UTC
Federico: In GConf. See /desktop/gnome/url-handlers/cdda. I don't have a handler
installed for that either. Note that since "cdda" is not a valid method, we
won't be able to generate GnomeVFSURIs from it, so the client application will
have to convert it to the CD-ROM URI.
Comment 10 Federico Mena Quintero 2005-09-20 17:52:10 UTC
Seb123 pointed me to the Fedora patch to fix this; they install a shell script
as  the handler for cdda URIs, and the shell script strips the URI and feeds it
to the default handler for audio CDs as configured in gnome-volume-manager.

I started this discussion on the issue:
http://mail.gnome.org/archives/desktop-devel-list/2005-September/msg00161.html
Comment 11 Christian Krause 2005-10-27 18:27:52 UTC
Hi,

please apologize the bugspam, but I don't understand why the proposed patch (at
least the removing of the cdda entry from default-modules.conf) is not applied
yet, even if this would fix the reported bug. Comment #6 points out, that having
a cdda entry in the default file is clearly a bug because if cdda is enabled, an
additional .conf file would be included. As far as I understand the other
comments are about a different problems (what happens if I "open" or double
click a cdrom icon, ...) and not about the reported error message. 

To get a better gnome without these many small annoying bugs it would be good if
such problems could be handled independend. This would keep bugzilla clean and
helps user/contributers like me to save time without searching for bugs like
this which are solved in theory months ago but not commited to CVS and released
as stable tarball.

I can confirm the default-modules.conf part of the proposed patch clearly solves
the reported problem.

Best regards,
Christian

btw, I reported http://bugzilla.gnome.org/show_bug.cgi?id=317707 about
doubleclicking a cdrom nautilus icon nearly a month ago and nobody has even set
this to NEW. :-(
Comment 12 Federico Mena Quintero 2005-11-01 02:50:25 UTC
*** Bug 317707 has been marked as a duplicate of this bug. ***
Comment 13 Brent Smith (smitten) 2005-12-29 20:01:06 UTC
what is going on with this bug?
Comment 14 Christian Krause 2005-12-30 20:43:55 UTC
(In reply to comment #13)
> what is going on with this bug?
Please read my comment #11:

As far as I understand the probleme there are 2 bugs:
1. the mentioned error message occurs even if cdda is _not_ turned on with --enable-cdda 
This bug could be very easy solved by just removing the entry for cdda from the default-modules.conf (because if cdda would be enabled, an additional cdda-modules.conf would be used). This is clearly a bug and can be solved by removing _one_ line.

2. when clicking a cdrom icon an error box is shown: couldn't display cdda://...
Solving this problem seems to be not so easy.

Best regards,
Christian

Comment 15 Alexander Larsson 2006-04-24 10:34:29 UTC
Removed from defaults.conf.