After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315457 - [adder] reports time position improperly
[adder] reports time position improperly
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.10
Other Linux
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on: 309218
Blocks:
 
 
Reported: 2005-09-07 14:27 UTC by Akos Maroy
Modified: 2005-10-08 21:33 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
a patch solving the issue (1.71 KB, patch)
2005-09-07 14:28 UTC, Akos Maroy 		committed Details | Review

Description Akos Maroy 2005-09-07 14:27:36 UTC 
when querying an adder element, it improperly reports the time position, as it
dispatches the question to the elements connected to its sink pads. but
naturally, as these elements are to be added together by adder, neither will
produce the current time position properly.

therefore the adder needs to keep track of the position itself.
Comment 1 Akos Maroy 2005-09-07 14:28:47 UTC 
Created attachment 51921 [details] [review]
a patch solving the issue

this patch adds a custom query function to the source pad of the adder element,
returning the correct time position.
Comment 2 Andy Wingo 2005-10-06 14:27:35 UTC 
Patch looks good
Comment 3 Tim-Philipp Müller 2005-10-08 21:33:21 UTC 
Thanks, committed to 0.8 branch:

2005-10-08  Akos Maroy  <darkeye at tyrell dot hu>

        Reviewed by: Tim-Philipp Muller  <tim at centricular dot net>

        * gst/adder/gstadder.c: (gst_adder_init), (gst_adder_query):
          Add query function to soure pad so adder reports the correct
          time/sample position when queried. (#315457)

 Cheers
  -Tim