After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315232 - throbber uses lots of cpu
throbber uses lots of cpu
Status: RESOLVED FIXED
Product: epiphany
Classification: Core
Component: Interface
1.7.x
Other All
: Normal minor
: ---
Assigned To: Epiphany Maintainers
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-09-04 13:19 UTC by Andy Wingo
Modified: 2005-10-02 11:22 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
don't spin hidden spinners (3.07 KB, patch)
2005-09-04 17:33 UTC, Christian Persch
committed Details | Review

Description Andy Wingo 2005-09-04 13:19:36 UTC
Please describe the problem:
I start my computer and there is no net access. Epiphany however wants to go to
the sites I last had open, and the throbber is running the whole time. This
actually consumes more cpu than playing an ogg in rhythmbox. I switch to the
ephiphany window, click ok on the dialogs telling me it can't get to the sites,
and the cpu use goes down noticeably.

Epiphany 1.7.6 on breezy ppc.

Steps to reproduce:
1. Unplug your network cable
2. Open a few tabs for different web sites
3. Check cpu usage


Actual results:
About 3,5% cpu usage per tab when the powerbook is running at half-speed (750
MHz). So if you have 5 tabs that epiphany wants to open, that's like 18,5% of
the cpu doing nothing, even if it's on another destop.

Expected results:
For it not to hog my cpu :)

Does this happen every time?
Yes

Other information:
Forward upstream from http://bugzilla.ubuntu.com/show_bug.cgi?id=13566
Comment 1 Christian Persch 2005-09-04 17:08:20 UTC
I'm not sure why it's using so much CPU... it's just painting a tiny pixbuf.
Admittedly, it's doing that 10 times per second, but lowering that frequency
makes the display be noticeably stuttering...
Comment 2 Christian Persch 2005-09-04 17:33:20 UTC
Created attachment 51794 [details] [review]
don't spin hidden spinners

One tiny optimisation is not to spin unmapped spinners (i.e. hidden ones, those
where the tab label is hidden). Can you try if this makes any difference?
Comment 3 Christian Persch 2005-09-19 10:24:26 UTC
Ping?
Comment 4 Christian Persch 2005-10-01 21:12:04 UTC
I committed this patch. Closing this bug because of lack of response from the
reporter; if the bug persists in 1.8.1 please re-open.
Comment 5 Andy Wingo 2005-10-02 11:22:49 UTC
Sorry for not responding, and thanks for making the patch. I'll update my CVS
and give it a go.