After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 315132 - [PATCH] UI polish: Use image menu item instead of plain menu item for network places/removable media
[PATCH] UI polish: Use image menu item instead of plain menu item for network...
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: panel
2.11.x
Other All
: High enhancement
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-09-02 16:25 UTC by Christian Neumair
Modified: 2005-09-18 08:05 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
Proposed patch (826 bytes, patch)
2005-09-02 16:26 UTC, Christian Neumair 		none Details | Review

Description Christian Neumair 2005-09-02 16:25:43 UTC 
Setting priority to high since this is a very visible UI glitch.
Comment 1 Christian Neumair 2005-09-02 16:26:24 UTC 
Created attachment 51728 [details] [review]
Proposed patch
Comment 2 Vincent Untz 2005-09-17 20:10:32 UTC 
Hrm... I'm not sure I see a difference here. Is it supposed to make these items
"bigger"?
Comment 3 Christian Neumair 2005-09-17 20:21:06 UTC 
Yes. The application menu uses those with NULL pixbufs as well if no image is
used for a desktop file. It's odd to have a few dozen equally-sized menu entries
except for two.
Comment 4 Vincent Untz 2005-09-18 08:05:26 UTC 
This patch clearly doesn't work for me. I've committed something else to HEAD.

2005-09-18  Vincent Untz  <vuntz@gnome.org>

	* panel-menu-items.c: (panel_place_menu_item_append_volumes): do as if
	we were loading icons for the items when there's a submenu. Thus,
	items are not smaller than the other ones anymore. Finding good icons
	would be better, though ;-)
	Fix bug #315132.