GNOME Bugzilla – Bug 314955
[PATCH] Summer of code Shared Music Rooms patch
Last modified: 2010-02-25 17:33:13 UTC
I'm posting my current patch here per google's requirements. This is supposed to work with gshrooms which can be found on Gnome CVS under module 'gshrooms'
Created attachment 51613 [details] [review] rb-gshrooms-3.patch Third revision of the patch
Created attachment 51614 [details] rhythmbox-buddies.png The icon that must be added to rhythmbox/data/art/ For more infos please visit http://raphael.slinckx.net/gshrooms.php
Created attachment 52949 [details] [review] update to rb-player-gst.c slightly hackishly fixes the caps renegotiation problems when seeking
Thanks ! I merged this in my gshrooms patch, and i also removed the need for patched gstreamer cause the patch will only make it in gstreamer 0.9. Using old tcp sockets instead. Updated my webpages with instructions, and the CVS gshrooms Thanks again !
*** Bug 306317 has been marked as a duplicate of this bug. ***
Probably should be reworked as a plugin.
Indeed, i'll do it when i get time for it, i'm also wiating for a better streaming solution, which is slowly emerging (ala google talk) with telepathy
Created attachment 63315 [details] [review] rb-gshrooms.patch Latest patch applying against CVS HEAD as of today. It only works when compiling with gstreamer 0.8 I hope i won't have to maintin it too much in the future to port it to a plugin, as noted above i'm waiting abit. (Note: the attached icon is no longer necessary)
Created attachment 63316 [details] [review] rb-gshrooms.patch Latest patch applying against CVS HEAD as of today. It only works when compiling with gstreamer 0.8 I hope i won't have to maintin it too much in the future to port it to a plugin, as noted above i'm waiting abit. (Note: the attached icon is no longer necessary)
(In reply to comment #9) > Latest patch applying against CVS HEAD as of today. > It only works when compiling with gstreamer 0.8 Any chance you could make it work with gstreamer 0.10? Most current distros ship with rhythmbox compiled against gstreamer 0.10. Or would it be better to wait until it is ported to the plugin framework?
Better wait for plugin framework to be ready. Using 0.10 is no big deal, 0.8 code will mostly work without modifications. But, the gshrooms server uses 0.8 needs to be ported, and also the gaim plugin uses the soon-to-be-deprectaed gaim 1.x interface for plugins.. So all in all this needs a wide review to get ported to latest libs and interfaces. When i get some time
I think we could close this bug as OBSOLETE, I'm not sure the patch will be updated now.
The whole idea seems to have been abandoned.