After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314814 - gnome-applets is not multithreaded-build safe
gnome-applets is not multithreaded-build safe
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: keyboard indicator (gswitchit)
git master
Other All
: High normal
: ---
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-30 05:00 UTC by Allison Karlitskaya (desrt)
Modified: 2005-08-30 17:02 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
patchtastic (1.31 KB, patch)
2005-08-30 05:57 UTC, Allison Karlitskaya (desrt) 		committed Details | Review

Description Allison Karlitskaya (desrt) 2005-08-30 05:00:15 UTC 
building gnome applets with 'make -j3' crashes on gswitchit.  as far as i can
tell, this is caused by the gswitchit depending on libkbdraw being built already
but this information not being codified in the makefile.

we really need to look at this before 2.12.
Comment 1 Allison Karlitskaya (desrt) 2005-08-30 05:52:28 UTC 
I was a bit off.  This isn't libkbdraw.  It's an internal dependency problem
inside the gswitchit directory.

Basically, gnome-keyboard-applet depends on libgswitchit-applet.a

The rule looks like:

gnome_keyboard_applet_LDADD = $(COMMON_LIBS) \
                         $(GNOME_APPLETS_LIBS) \
                         $(top_builddir)/gswitchit/libgswitchit-applet.a

where top_builddir is '..'

So gnome-keyboard-applet tries to build "../gswitchit/libgswitchit-applet.a" and
gets:

make[1]: *** No rule to make target `../gswitchit/libgswitchit-applet.a', needed
by `gnome-keyboard-applet'.  Stop.

Changing from "$(top_builddir)/gswitchit/libgswitchit-applet.a" to simply
"libgswitchit-applet.a" causes make to try (and succeed at) building
"libgswitchit-applet.a" and thus fixes the problem.
Comment 2 Allison Karlitskaya (desrt) 2005-08-30 05:57:20 UTC 
Created attachment 51542 [details] [review]
patchtastic

what's the etiquette for changes to makefiles made during hard code freeze?
Comment 3 Allison Karlitskaya (desrt) 2005-08-30 17:02:19 UTC 
doot.