GNOME Bugzilla – Bug 314708
filesrc doesn't set GST_BUFFER_FLAG_READONLY on mmaped buffers
Last modified: 2005-08-31 12:58:11 UTC
in gst/elements/filesrc.c:504 GST_BUFFER_FLAG_SET (buf, GST_BUFFER_READONLY) is commented. That makes gst_buffer_make_writable (buf) return the same buffer and not a copy of it, causing a segfault when modifying the buffer.
Nice catch, thanks! Should be fixed in CVS now. 2005-08-31 Tim-Philipp Mueller <tim at centricular dot net> * gst/elements/gstfilesrc.c: (gst_mmap_buffer_init), (gst_file_src_map_region): Set READONLY flag on mmap'ed buffers, otherwise gst_buffer_make_writable() won't work properly (#314708). Cheers -Tim