After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314708 - filesrc doesn't set GST_BUFFER_FLAG_READONLY on mmaped buffers
filesrc doesn't set GST_BUFFER_FLAG_READONLY on mmaped buffers
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gstreamer (core)
git master
Other Linux
: Normal normal
: 0.9.2
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-28 13:25 UTC by Alessandro Decina
Modified: 2005-08-31 12:58 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10



Description Alessandro Decina 2005-08-28 13:25:34 UTC
in gst/elements/filesrc.c:504
GST_BUFFER_FLAG_SET (buf, GST_BUFFER_READONLY) is commented.
That makes gst_buffer_make_writable (buf) return the same buffer
and not a copy of it, causing a segfault when modifying the buffer.
Comment 1 Tim-Philipp Müller 2005-08-31 12:58:11 UTC
Nice catch, thanks! Should be fixed in CVS now.

2005-08-31  Tim-Philipp Mueller  <tim at centricular dot net>

       * gst/elements/gstfilesrc.c: (gst_mmap_buffer_init),
       (gst_file_src_map_region):
         Set READONLY flag on mmap'ed buffers, otherwise
         gst_buffer_make_writable() won't work properly (#314708).

 Cheers
  -Tim