After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314664 - implicit pointer conversion might cause serious breakage on 64-bits arches
implicit pointer conversion might cause serious breakage on 64-bits arches
Status: RESOLVED FIXED
Product: bonobo
Classification: Deprecated
Component: libbonoboui
unspecified
Other Linux
: Normal major
: ---
Assigned To: Michael Meeks
bonobo qa
Depends on:
Blocks:
 
 
Reported: 2005-08-27 17:36 UTC by Loïc Minier
Modified: 2005-08-31 19:26 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
fix for implicit pointer warning (1.03 KB, patch)
2005-08-27 17:37 UTC, Loïc Minier 		none Details | Review
Don't use gnome_i18n_get_language_list (1.73 KB, patch)
2005-08-30 16:35 UTC, Gustavo Carneiro 		none Details | Review

Description Loïc Minier 2005-08-27 17:36:43 UTC 
Version details: Debian's 2.10.0-1
Distribution/Version: Debian/sid

Hi,

Dann Frazier reported in Debian bug <http://bugs.debian.org/318651> that
libbonoboui 2.10.0 builds with a dangerous warning on the ppc64 arch.  This
warning might indicate a conversion which might cause serious breakage on 64-bit
arches.

He proposed a small patch against bonobo/Makefile.in and
bonobo/bonobo-selector-widget.c, and I checked that
bonobo/bonobo-selector-widget.c wasn't fixed in 2.10.1.

Please review and include this patch.  I don't know why, but the Makefile.in
part seems irrelevant now.

Bye,
Comment 1 Loïc Minier 2005-08-27 17:37:53 UTC 
Created attachment 51427 [details] [review]
fix for implicit pointer warning
Comment 2 Loïc Minier 2005-08-27 17:57:22 UTC 
Hmm, no my mistake, the Makefile.in part still applies.
Comment 3 Michael Meeks 2005-08-30 10:06:21 UTC 
Why do we want to start using deprecated APIs ? - sounds duff to me ;-)
Comment 4 Loïc Minier 2005-08-30 11:24:51 UTC 
No idea, I didn't try understanding the patch.  Do you have a better fix in CVS?
Comment 5 Gustavo Carneiro 2005-08-30 16:35:14 UTC 
Created attachment 51561 [details] [review]
Don't use gnome_i18n_get_language_list

I think this is a better fix.
Comment 6 Loïc Minier 2005-08-30 19:31:40 UTC 
I've rebuilt with the patch and compared build logs (I don't have access to
64-bit systems), everything seems fine.  The warning disappears with this patch too.
Comment 7 Michael Meeks 2005-08-31 10:55:34 UTC 
Looks great Gustavo - please do commit wherever you see fit :-)
Comment 8 Gustavo Carneiro 2005-08-31 19:26:25 UTC 
ok, committed