After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314593 - Firefox can not be selected to build the mozilla-plugin
Firefox can not be selected to build the mozilla-plugin
Status: RESOLVED FIXED
Product: librsvg
Classification: Core
Component: general
2.11.x
Other Linux
: Normal normal
: ---
Assigned To: librsvg maintainers
librsvg maintainers
: 314711 317250 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-08-26 15:59 UTC by Joseph Sacco
Modified: 2005-10-02 14:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12



Description Joseph Sacco 2005-08-26 15:59:26 UTC
Version details: 2.11.0
Distribution/Version: YDL-4.0.1

The configure file is hard-wired to use mozilla as the gecko engine to build the
mozilla-plugin.

Looking at the configuration file, there appears to be some initial work in
place to allow the user to override the default choice by using an environment
variable, MOZILLA_CONFIG. The work is not [yet] complete. Package configuration
file names,

   * mozilla-config
   * mozilla-plugin

are hard-wired into the code.

For now, the simple work-around is to configure librsvg and then hack the
moz-plugin Makefile, modifying MOZILLA_CFLAGS.
Comment 1 Dominic Lachowicz 2005-08-28 22:22:05 UTC
*** Bug 314711 has been marked as a duplicate of this bug. ***
Comment 2 Dominic Lachowicz 2005-09-26 14:38:34 UTC
*** Bug 317250 has been marked as a duplicate of this bug. ***
Comment 3 Dominic Lachowicz 2005-10-01 16:33:25 UTC
should be fixed.
Comment 4 Joseph Sacco 2005-10-02 00:55:08 UTC
Not quite... the autodection code for (mozilla|firefox)-config is broken.

(1) configure fails to detect firefox-config when firefox-config is in the
search path [mozilla-config is not in the search path]

(2) if the user sets the environment variable, 

   MOZILLA_CONFIG=firefox-config

 which short-circuits auto detection, all is well.

If you do not have firefox-config within your search path but do have
mozilla-config, you can see the problem with the autodetect code, by swapping
the order of mozilla-config and firefox-config tests in configure.in. 

-Joseph
Comment 5 Joseph Sacco 2005-10-02 04:11:13 UTC
I puzzled over configure.in for a while and came up with something that works:

--- configure.in-       2005-10-01 14:50:53.000000000 -0400
+++ configure.in        2005-10-02 00:05:26.000000000 -0400
@@ -377,11 +377,7 @@

 if test "x$test_mozilla_plugin" != "xno"; then
    if test -z "$MOZILLA_CONFIG"; then
-      AC_PATH_PROG(MOZILLA_CONFIG, mozilla-config, no)
-   fi
-
-   if test "x$MOZILLA_CONFIG" = "xno"; then
-      AC_PATH_PROG(MOZILLA_CONFIG, firefox-config, no)
+      AC_PATH_PROGS(MOZILLA_CONFIG, mozilla-config firefox-config, no)
    fi

    if test "x$MOZILLA_CONFIG" != "xno"; then

-Joseph
Comment 6 Dominic Lachowicz 2005-10-02 04:23:30 UTC
thanks.
Comment 7 Joseph Sacco 2005-10-02 14:50:57 UTC
you are welcome...

You may wish to give some consideration to making MOZILLA_CONFIG a configuration
option rather than an environment variable by giving the user the option to
select the gecko engine with which to build the plugin:

   --with-gecko = firefox or mozilla


-Joseph