After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314486 - [PATCH] let file browser treeview grab focus when switching directory though the path bar
[PATCH] let file browser treeview grab focus when switching directory though ...
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: GtkFileChooser
2.7.x
Other Linux
: Normal normal
: ---
Assigned To: gtk-bugs
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-08-25 19:19 UTC by Carlos Garnacho
Modified: 2011-02-04 16:19 UTC
See Also:
GNOME target: 2.12.x
GNOME version: 2.11/2.12

Attachments
the silly patch (547 bytes, patch)
2005-08-25 19:20 UTC, Carlos Garnacho 		needs-work Details | Review

Description Carlos Garnacho 2005-08-25 19:19:17 UTC 
the following one-liner patch makes the file browser treeview grab the focus
when using the path bar, so the user could type filenames without using the
mouse again or using TAB to change focus.
Comment 1 Carlos Garnacho 2005-08-25 19:20:20 UTC 
Created attachment 51336 [details] [review]
the silly patch
Comment 2 Raphael Slinckx 2005-09-10 14:34:03 UTC 
I don"t know about the patch validity, but this small issue is getting really
annoying, can it be fixed ?
Comment 3 Federico Mena Quintero 2005-11-07 17:44:25 UTC 
Go ahead and commit.  Thanks for the patch :)
Comment 4 Federico Mena Quintero 2005-11-07 18:52:36 UTC 
Actually, Matthias pointed out that it may be better to just make the buttons
not focus on click.  That will work better for keynav.

Garnacho: could you please make the buttons gtk_button_set_focus_on_click (b,
FALSE)?
Comment 5 Matthias Clasen 2005-11-07 20:02:20 UTC 
2005-11-07  Matthias Clasen  <mclasen@redhat.com>

	* gtk/gtkpathbar.[hc]: Set focus-on-click to FALSE for all buttons.
	Don't grab focus when a slider button is pressed, instead, use
	a bit in the pathbar struct to determine whether to scroll up
	or down.  (#314486, Carlos Garnacho)