After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314366 - gnome-applets build fixes on FreeBSD
gnome-applets build fixes on FreeBSD
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: general
2.10.x
Other All
: High normal
: 2.12
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-24 10:10 UTC by Diego Elio Pettenò
Modified: 2005-08-25 02:07 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
gnome-applets-2.10.1-fbsd.patch (1.46 KB, patch)
2005-08-24 10:10 UTC, Diego Elio Pettenò
committed Details | Review

Description Diego Elio Pettenò 2005-08-24 10:10:06 UTC
Please describe the problem:
The attached patch is needed to have gnome-applets compile clean on FreeBSD 
(specifically, Gentoo/FreeBSD). 
It's a modified version of the patches in FreeBSD's ports to use the configure 
script instead of __FreeBSD__ definition to consider pty.h and values.h 
present. 
 
HTH, 
Diego 

Steps to reproduce:
 

Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Diego Elio Pettenò 2005-08-24 10:10:34 UTC
Created attachment 51241 [details] [review]
gnome-applets-2.10.1-fbsd.patch
Comment 2 Danielle Madeley 2005-08-25 01:38:37 UTC
Intuition suggests that these will still be needed. Can someone confirm?
Comment 3 Allison Karlitskaya (desrt) 2005-08-25 02:07:31 UTC
==> ChangeLog <==
2005-08-24  Ryan Lortie  <desrt@desrt.ca>

        * configure.in: Add checks for non-portable headers <pty.h> and
          <values.h>.  Patch from Diego Pettenò <flameeyes@gentoo.org> closes
          bug #314366.

==> gweather/ChangeLog <==
2005-08-24  Ryan Lortie  <desrt@desrt.ca>

        * weather.c: Conditionalise the #inclusion of <values.h>.  Patch from
          Diego Pettenò <flameeyes@gentoo.org> closes bug #314366.


==> modemlights/ChangeLog <==
2005-08-24  Ryan Lortie  <desrt@desrt.ca>

        * modem-applet.c: Conditionalise #inclusion of <pty.h>.  Add the
          FreeBSD equivilents inside an #ifdef __FreeBSD__.  Patch from
          Diego Pettenò <flameeyes@gentoo.org> closes bug #314366.