After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 314346 - Clicking "add wallpaper", "File System" icon and Pathbar are bigger than the others gtk2 program on gtkfilechooer.
Clicking "add wallpaper", "File System" icon and Pathbar are bigger than the...
Status: RESOLVED FIXED
Product: adwaita-icon-theme
Classification: Core
Component: general
2.11.x
Other All
: Normal normal
: ---
Assigned To: Jakub Steiner
Control-Center Maintainers
: 312060 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-08-24 07:13 UTC by sangu
Modified: 2006-01-05 07:15 UTC
See Also:
GNOME target: 2.12.x
GNOME version: 2.11/2.12


Attachments
AddWallper GtkFileChooser (72.30 KB, image/jpeg)
2005-08-24 07:17 UTC, sangu
Details
This is how the file dialog should look with gnome icon theme. (49.71 KB, image/png)
2005-08-24 11:58 UTC, Jakub Steiner
Details
Screenshot (7.46 KB, image/png)
2005-08-26 08:02 UTC, Michael Monreal
Details

Description sangu 2005-08-24 07:13:57 UTC
Please describe the problem:
Clicking "add wallpaper",  "File System" icon and Pathbar are bigger than the
others gtk2 programs on gtkfilechooer.

Steps to reproduce:
1. Execute gnome-background-properties
2. Click "add wallpaper"
3. 


Actual results:


Expected results:


Does this happen every time?
always

Other information:
gnome-icon-theme-2.11.92, gtk+ 2.8.0, control-center 2.11.91
Comment 1 sangu 2005-08-24 07:17:44 UTC
Created attachment 51228 [details]
AddWallper GtkFileChooser
Comment 2 Sebastien Bacher 2005-08-24 09:15:04 UTC
gnome-icon-theme issue, the icon has no other variant than 48x48 and they use
"Fixed" for it
Comment 3 Jakub Steiner 2005-08-24 09:56:09 UTC
That appears like Industrial, not git though. While gnome icon theme has been
reverted to use scaled for 48x48, the file dialog definitely has all the used
artwork at 16x16. I really wonder what's wrong here, as Industrial should be
inheriting git.
Comment 4 Sebastien Bacher 2005-08-24 10:15:20 UTC
$ find /usr/share/icons/gnome -name
gnome-fs-blockdev.png/usr/share/icons/gnome/48x48/filesystems/gnome-fs-blockdev.png

there is no 16x16 variant and it the index uses "Fixed" ...
Comment 5 Jakub Steiner 2005-08-24 11:06:14 UTC
So this changed? It used to be gnome-dev-harddisk
Comment 6 Sebastien Bacher 2005-08-24 11:26:23 UTC
$ grep "gnome-fs" gtk/gtkfilesystemunix.c
  pixbuf = get_cached_icon (widget, "gnome-fs-blockdev", pixel_size);
    return "gnome-fs-directory";
    return "gnome-fs-home";
    return "gnome-fs-desktop";
    return "gnome-fs-directory";
      name = "gnome-fs-blockdev";
      name = "gnome-fs-symlink";
      name = "gnome-fs-chardev";
      name ="gnome-fs-executable";
      name = "gnome-fs-fifo";
      name = "gnome-fs-socket";
  pixbuf = get_cached_icon (widget, "gnome-fs-regular", pixel_size);

Not sure if this changed, but that's with GTK 2.8.1
Comment 7 Jakub Steiner 2005-08-24 11:53:33 UTC
While blockdev should be scaled down again, I really think harddisk should be
used as it's the case with my suse 9.3 and ubuntu hoary.
Comment 8 Jakub Steiner 2005-08-24 11:57:18 UTC
Aha! So it looks like the wallpaper file dialog is using blockdev even on my
system while it's harddisk everywhere else. It should be changed to use the same
icon (harddisk) as everything else.
Comment 9 Jakub Steiner 2005-08-24 11:58:56 UTC
Created attachment 51248 [details]
This is how the file dialog should look with gnome icon theme.
Comment 10 Sebastien Bacher 2005-08-24 12:29:18 UTC
your screenshot is the gnome-vfs mode for the fileselector, not the gtk+ -mode
(you can change /desktop/gnome/interface/file_chooser_backend and try with an
another application). 
Comment 11 Jakub Steiner 2005-08-24 12:43:54 UTC
Hmmk, let me rephrase it then. Please make the gtk backend use
gnome-dev-harddisk as the gnome-vfs backend does. While blockdev is now being
scaled down, it looks worse than dev-harddisk whcih is available in multiple
resolutions.
Comment 12 Sebastien Bacher 2005-08-24 13:05:42 UTC
I've opened bug #314382 about the icon change.
Comment 13 Jakub Steiner 2005-08-24 13:11:49 UTC
Thank you. As the size issue has been fixed by making 48x48 scalable again, I'm
closing this one.
Comment 14 Sebastien Bacher 2005-08-24 13:31:05 UTC
The CVS has still:

"[48x48/filesystems]
Size=48
Context=FileSystems
Type=Fixed"

Since GNOME 2.12 is going to ship with GTK 2.8.1 which uses "gnome-fs-blockdev",
could you change that one to "Scalable" too?
Comment 15 Alexander Larsson 2005-08-25 15:43:28 UTC
The same problem is showing up in nautilus. The menu item icon for "Empty file"
in the templates menu is 48x48. (This is gnome-fs-regular, in contect filesystems).
Comment 16 Alexander Larsson 2005-08-25 15:44:25 UTC
jimmac: Did you really change it?
Like seb says, its not changed in cvs HEAD.
Comment 17 Sebastien Bacher 2005-08-25 17:03:53 UTC
*** Bug 312060 has been marked as a duplicate of this bug. ***
Comment 18 Sebastien Bacher 2005-08-25 17:05:01 UTC
reopening, that's not fixed
Comment 19 Luis Villa 2005-08-25 17:16:52 UTC
High visibility; still happening.
Comment 20 Michael Monreal 2005-08-26 08:01:01 UTC
To bring the problem from 312060 (which has been marked as a dupe) again here:
Create Documents->Empty File also uses a 48x48 icon instead of 24x24.

Also, the icons in "Recent Documents" in the panel were drawn to big in my
previous install, this is (maybe) fixed now after building everything from
scratch but there still seem to be *some* icons that are a bit too big (but not
48x48 size)
Comment 21 Michael Monreal 2005-08-26 08:02:27 UTC
Created attachment 51369 [details]
Screenshot

The first icon (jpg) is bigger
Comment 22 Jakub Steiner 2005-08-26 11:27:15 UTC
2005-08-26  Jakub Steiner <jimmac@ximian.com>

	* index.theme.in: also make 48x48 filesystems 
	  scalable (as per bug #314346

For any other 48x48 icons showing up improperly, could you please provide the
filename so that I could draw the missing 16x16 and 24x24 bit?
Comment 23 Michael Monreal 2005-08-27 11:56:03 UTC
The mime icons in recent documents having the wrong size (32x32 instead of
24x24) can also be fixed by making 32x32 mime icons scalable in index.theme...
Anyone considered doing this?
Comment 24 Luis Villa 2005-08-27 18:15:48 UTC
Michael, you're sure you have GTK HEAD? those work fine here.
Comment 25 Michael Monreal 2005-09-05 20:08:23 UTC
I havn't updated gtk in recent days but this is at least a "a few days after
2.8.0 final release" cvs snapshot... Otherwise clean build so I asume this is
what I can expect if I rebuild everything. Anyway it's not that bad...