GNOME Bugzilla – Bug 314180
Places->Recent Documents should be greyed out when empty
Last modified: 2005-10-22 13:16:06 UTC
Please describe the problem: When there are no recent documents, the menu expands to include only a seperator and "Clear recent documents" instead of being greyed out. Steps to reproduce: 1. Expand Places->Recent Documents. 2. Make sure you have no entries by clearing it. 3. Expand Places->Recent Documents again. Actual results: You get a submenu with only a seperator and "Clear recent documents." Expected results: That the menu "Recent Documents" was greyed out. Does this happen every time? Yes. Other information:
Err .. It's greyed out now. I just ran a upgrade here and might have gotten a gnome-panel upgrade from like 2.11.90 -> 2.11.91 or something, but no bigger version jump.. Was it really fixed just now?
Confirmed with gnome-applets 2.11.91 on Ubuntu Breezy, but does not happen every time.
Created attachment 51154 [details] screenshot of the problem
I doubt you confirmed it with gnome-applets 2.11.91, but perhaps with gnome-panel 2.11.92-0ubuntu1. :)
Fixed in HEAD.
vuntz: I know you said "HEAD", but I don't know if 2.12 was branched at that point or not .. Should this fix be in 2.12? (because if it is, I'm still seeing this bug)
Vidar: it should be fixed in 2.12.1.
Created attachment 53755 [details] problem is still there I'm using gnome-applets 2.12.1-0ubuntu1 and gnome-panel 2.12.1-0ubuntu7, so I'm guessing I should have the fix, then. However, as this screenshot demonstrates, the problem is still present (although note that it now does not include the seperator item that is there in the previous screenshot.)
It should be noted that my recent documents history includes alot of documents that live on a disk I do not have mounted at the moment (but also documents that live on the current disk). When I do 'sudo mount -a' the recent menu works. When I do 'sudo umount /mnt/that-drive' the menu appears as in attachment 53755 [details]. I can repeat this over and over again to produce attachment 53755 [details].
Since I wrote the last comment I've been running with the drive unmounted, and now the items suddenly appeared again (even though most of the items there point to a non-existant location now) ... I remounted the drive and they disappeared again (!), unmounted and remounted it again and they still do not show (although now the items, as you understand, do exist) ... This is not making me any wiser, I hope vuntz understands a bit more of what's going on :-)
Can you compile the panel with this patch: Index: panel-recent.c =================================================================== RCS file: /cvs/gnome/gnome-panel/gnome-panel/panel-recent.c,v retrieving revision 1.36 diff -u -p -r1.36 panel-recent.c --- panel-recent.c 18 Sep 2005 13:41:52 -0000 1.36 +++ panel-recent.c 22 Oct 2005 08:53:09 -0000 @@ -113,7 +113,7 @@ panel_recent_model_changed_cb (EggRecent GList *list, GtkWidget *menu_item) { - if (list) + if (list && g_list_length (list) > 0) gtk_widget_set_sensitive (menu_item, TRUE); else gtk_widget_set_sensitive (menu_item, FALSE);
I did 'apt-get source gnome-applets', 'dpkg-source -x gnome-applets-XX.dsc', applied the patch and did 'dpkg-buildpackage -rfakeroot -b', and went to get something to eat. When I first returned the ./configure was done and it had started building it seemed, because the mouse was lagging alot and the computer was churning away. When I returned just now, there were no windows (where I had several Firefoxes, Thunderbird, XChat, terminals, etc etc when I left) and no processes (except the normal ones) running. I have no idea what has happened, but what I see before me is how the system appears after a fresh boot, and no .deb file has been generated. In any case, the patch in comment 11 does not appear to fix the issues where: * Recent files, either from currently mounted or currently not mounted disks, do not show in the list. * Files from not mounted disks do show (I'm not sure they should - and if so maybe they should be greyed out?).
(it should be noted that I have auto-login in GDM, so it could be possible that the system has, in fact, rebooted for some reason ... but this surely isn't a gnome-panel related bug in any case)
Vidar: did you apply the patch to the panel? gnome-applets has nothing to do with this bug :-)
The patch applied cleanly; I just wrote applets in my comment here for some reason :-P In any case that wouldn't explain what happened .. :-)
Vidar: if you didn't install a new deb file, then you're still using the unpatched panel ;-) I suggest you do: apt-get build-dep gnome-panel && debuild
Yes, but as I said, doing 'dpkg-buildpackage -rfakeroot -b' crashed my entire system and apparently rebooted the computer. I tried again using 'debuild' instead of 'dpkg-buildpackage -rfakeroot -b', and got this output: Trying patch debian/patches/12_autotools.patch at level 0...1...2...failure. make: *** [debian/stamp-patched] Error 1 debuild: fatal error at line 765: dpkg-buildpackage failed! But, as I noted in the last paragraph in comment 12, the proposed patch from comment 11 won't actually fix the problems outlined in comment 8, 9 and 10; only hide them from the user.
Vidar: the patch should fix comment 8 and comment 9. Comment 10 is another bug, in egg-recent.
Ah, alright. I see how they're different issues. Anyway, it seems I'm not able to compile and test the patch, sorry.