GNOME Bugzilla – Bug 313812
metadata not found in ogg files without genre
Last modified: 2005-10-02 14:28:57 UTC
Distribution/Version: Fedora Core 4 If I rip a song in sound juicer without specifying a genre, gst_media_info_read stores the metadata in the streaminfo field and discards the streaminfo. I have attached a copy of a track ripped with and without a genre. If rip a track without a genre I get this: ~/gst-plugins-0.8.10/gst-libs/gst/media-info% ./media-info-test Prison_Song_Bad_Cut.ogg stream: (nil), &stream: 0xbfca5984 iterated a few times, didn't find metadata FIXME: implement getting length of whole track FILE: Prison_Song_Bad_Cut.ogg stream: 0x816cdd0, &stream: 0xbfca5984 - mime type: application/ogg - length: 5.345 seconds - bitrate: 76.633 kbps - number of tracks: 1 - track 0 - metadata: (none found) - streaminfo: title: Prison Song artist: System of a Down track number: 1 track count: 14 album: Toxicity encoder: Xiph.Org libVorbis I 20040629 encoder version: 0 audio codec: Vorbis nominal bitrate: 160000 bitrate: 160000 - format: audio/x-raw-float, rate=(int)44100, channels=(int)2, endianness=(int)1234, width=(int)32, buffer-frames=(int)0 if a genre is specified I get this: ~/gst-plugins-0.8.10/gst-libs/gst/media-info% ./media-info-test Prison_Song_Good_Cut.ogg stream: (nil), &stream: 0xbfa45e94 FIXME: implement getting length of whole track FILE: Prison_Song_Good_Cut.ogg stream: 0x816cdd0, &stream: 0xbfa45e94 - mime type: application/ogg - length: 5.345 seconds - bitrate: 76.633 kbps - number of tracks: 1 - track 0 - metadata: title: Prison Song artist: System of a Down track number: 1 track count: 14 album: Toxicity genre: Rock encoder: Xiph.Org libVorbis I 20040629 encoder version: 0 audio codec: Vorbis nominal bitrate: 160000 bitrate: 160000 - streaminfo: serial: 1003046990 - format: audio/x-raw-float, rate=(int)44100, channels=(int)2, endianness=(int)1234, width=(int)32, buffer-frames=(int)0
Created attachment 50900 [details] Ogg file with no genre
Created attachment 50901 [details] Ogg file with a genre
Created attachment 52586 [details] [review] change algorithm that looks if a taglist is mediainfo or streaminfo The previous algorithm worked as this: - if in the taglist there are more mediainfo tags than put all tags in the taglist as mediainfo. Otherwise put them all as streaminfo. I've changed it in a "more logical" (at least for me :)) ) alg: - if a tag is mediainfo put it in the mediainfo list - if a tag is streaminfo put it in the streaminfo list. This way if a element (like vorbisdec) emits a taglist with streaminfo and mediainfo tags the media-info lib correctly split them. New output with the patch: FILE: /home/luogni/Temp/ogggenre/1.ogg stream: 0x810f380, &stream: 0xbfcbf984 - mime type: application/ogg - length: 5,345 seconds - bitrate: 76,633 kbps - number of tracks: 1 - track 0 - metadata: titolo: Prison Song artista: System of a Down numero di traccia: 1 totale tracce: 14 album: Toxicity - streaminfo: seriale: 114258250 encoder: Xiph.Org libVorbis I 20040629 versione encoder: 0 codec audio: Vorbis bitrate nominale: 160000 bitrate: 160000 - format: audio/x-raw-float, rate=(int)44100, channels=(int)2, endianness=(int)1234, width=(int)32, buffer-frames=(int)0 (please test!)
Committed. Thanks for reporting the bug.