GNOME Bugzilla – Bug 313799
attachment bar freezes evolution
Last modified: 2013-09-13 00:53:31 UTC
+ Trace 62516
Thread 10 (Thread 131080 (LWP 3053))
Thread 9 (Thread 114695 (LWP 3052))
Thread 8 (Thread 98310 (LWP 3042))
Thread 7 (Thread 81925 (LWP 3041))
Thread 5 (Thread 49156 (LWP 2966))
Thread 4 (Thread 32771 (LWP 2965))
Thread 1 (Thread 16384 (LWP 2939))
this is on a message with 2 image attachments, the first of which fails to display at all because it is partially corrupt (other programs load the good part ok).
Created attachment 50890 [details] message from which the trace originates this doesn't happen every time, but it happens quite often showing this message
Created attachment 51089 [details] [review] Fixes the bug. This could be solved, if the resize of the bar, just resizes instead of invoking update, which refreshes the icons and everything. Im attaching a patch for it.
Created attachment 51103 [details] [review] This fixes the bug. ignore the previous one.
i think this patch is in the wrong place. "update" is being called from the mailer - i think that is the cause of the problem. i.e. the fact it is being called is wrong, not so much that what it does is wrong (although that is too). setting the size should auto-update as required, why is the update thing even being called in the mailer? also, a better calculation than having to use modality is something like: rows = (num_attachments + col - 1)/per_col;
modulus, not modality, duh
Created attachment 51169 [details] [review] reworked patch
Comment on attachment 50890 [details] message from which the trace originates Oops selected wrong one.
looks better, thanks
Committed to head.
Verified the same mail as source with Evolution 2.3.8.