After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313701 - gdmflexiserver "Choose server" dialog
gdmflexiserver "Choose server" dialog
Status: RESOLVED FIXED
Product: gdm
Classification: Core
Component: general
2.8.x
Other Linux
: Normal major
: ---
Assigned To: GDM maintainers
GDM maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-17 09:01 UTC by Sebastien Bacher
Modified: 2005-10-05 04:16 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
the dialog (9.51 KB, image/png)
2005-08-17 09:17 UTC, Sebastien Bacher
Details

Description Sebastien Bacher 2005-08-17 09:01:13 UTC
After updating from gdm 2.8.0.1 to 2.8.0.2 gdmflexiserver start a weird "Choose
server" with 3 "Standard server" options doing different things. This dialog
also has the buttons on the wrong order.
Comment 1 Sebastien Bacher 2005-08-17 09:17:54 UTC
Created attachment 50848 [details]
the dialog
Comment 2 Raphael Slinckx 2005-08-18 12:34:12 UTC
Confirming, same behavior on gentoo
Comment 3 Brian Cameron 2005-08-18 17:57:41 UTC
Hmmm, looking at the code I notice a possible bug.  The following line in
gdmflexiserver.c read_servers() function:

                        section = g_strdup_printf ("=%s=/%s/", config_file);

should have "=%s=/" as the first argument, I believe.  Looking at
gdmXnestchooser.c and gdmphotosetup.c, this is how they are working to do the
same thing.  Could you try fixing this and see if it corrects the problem. 
Solaris doesn't support virtual terminals so I can't test this.

If this doesn't fix the problem, it would be useful to put printf functions in
the read_servers() function and make sure that gdmflexiserver is reading the
right names from the configuration file.  The chooser_server() function that
displays the dialog is just looping over the "xservers" list that is build in
read_servers.  So I suspect the problem is in the way that the list is being
built.  I suspect that fixing the setting of the "section" variable as I
describe above is the problem.
Comment 4 Sebastien Bacher 2005-08-18 20:50:34 UTC
this change fixes the issue, thanks
Comment 5 Brian Cameron 2005-08-18 21:37:20 UTC
Thanks for checking.  Fixed in CVS head and in 2.12 branch.
Comment 6 Christiaan Welvaart 2005-10-04 20:13:44 UTC
The applied "fix" is wrong, see http://qa.mandriva.com/show_bug.cgi?id=18889 for
a description and patch.
Comment 7 Brian Cameron 2005-10-05 04:16:01 UTC
Thanks for catching this.  You are right.  Fixed in CVS head.