GNOME Bugzilla – Bug 313550
Switch back to highest speed failed
Last modified: 2005-09-01 21:47:56 UTC
Please describe the problem: with the kernel 2.6.12, a new governor has been introduced. When you enable all the governors, the list is too long. The bug is in cpufreq_sysfs_get_govs(), the buffer used by fgets to read the file scaling_available_governors is too small, so the list of available governors is truncated. Steps to reproduce: 1. You must have the following governor enable in you kernel : $ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors conservative ondemand powersave userspace performance select the lowest speed, the cpu frequence toggles to this speed 2. select the highest speed, the cpu frequence stays at the lowest speed 3. if you exec at the prompt /usr/bin/cpufreq-selector -f <speed>, the command fails with the message : Invalid governor performance Actual results: Expected results: Does this happen every time? Yes Other information:
Created attachment 51042 [details] [review] meow
Bang!
Set correct state. Ryan, commit it.
Fixed in HEAD.
This change regressed this bug: http://cvs.gnome.org/viewcvs/gnome-applets/cpufreq/src/cpufreq-selector/cpufreq-sysfs.c?r1=1.7&r2=1.8 Reopening, marking as a show-stopper. We're going to need release team approval on this one.
Created attachment 51677 [details] [review] rawr this refixes the bug. I'll email the release team.
Approvals from Luis and Vincent: http://mail.gnome.org/archives/release-team/2005-September/msg00007.html Committed to HEAD.