After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313550 - Switch back to highest speed failed
Switch back to highest speed failed
Status: RESOLVED FIXED
Product: gnome-applets
Classification: Other
Component: cpufreq
git master
Other Linux
: Immediate major
: 2.12
Assigned To: gnome-applets Maintainers
gnome-applets Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-15 18:33 UTC by Gilles Hamel
Modified: 2005-09-01 21:47 UTC
See Also:
GNOME target: 2.12.x
GNOME version: 2.11/2.12


Attachments
meow (5.55 KB, patch)
2005-08-21 01:11 UTC, Allison Karlitskaya (desrt)
committed Details | Review
rawr (633 bytes, patch)
2005-09-01 20:34 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Gilles Hamel 2005-08-15 18:33:45 UTC
Please describe the problem:
with the kernel 2.6.12, a new governor has been introduced. When you enable all
the governors, the list is too long. The bug is in cpufreq_sysfs_get_govs(), the
buffer used by fgets to read the file scaling_available_governors is too small,
so the list of available governors is truncated.


Steps to reproduce:
1. You must have the following governor enable in you kernel :
    $ cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors
conservative ondemand powersave userspace performance
   select the lowest speed, the cpu frequence toggles to this speed
2. select the highest speed, the cpu frequence stays at the lowest speed
3. if you exec at the prompt /usr/bin/cpufreq-selector -f <speed>, the command
fails with the message : Invalid governor performance 


Actual results:


Expected results:


Does this happen every time?
Yes

Other information:
Comment 1 Allison Karlitskaya (desrt) 2005-08-21 01:11:58 UTC
Created attachment 51042 [details] [review]
meow
Comment 2 Danielle Madeley 2005-08-21 11:43:02 UTC
Bang!
Comment 3 Danielle Madeley 2005-08-21 11:45:45 UTC
Set correct state. Ryan, commit it.
Comment 4 Allison Karlitskaya (desrt) 2005-08-21 15:30:31 UTC
Fixed in HEAD.
Comment 5 Allison Karlitskaya (desrt) 2005-09-01 20:29:05 UTC
This change regressed this bug:
http://cvs.gnome.org/viewcvs/gnome-applets/cpufreq/src/cpufreq-selector/cpufreq-sysfs.c?r1=1.7&r2=1.8

Reopening, marking as a show-stopper.  We're going to need release team approval
on this one.
Comment 6 Allison Karlitskaya (desrt) 2005-09-01 20:34:15 UTC
Created attachment 51677 [details] [review]
rawr

this refixes the bug.

I'll email the release team.
Comment 7 Allison Karlitskaya (desrt) 2005-09-01 21:47:56 UTC
Approvals from Luis and Vincent:
http://mail.gnome.org/archives/release-team/2005-September/msg00007.html


Committed to HEAD.