Bug 313397 – crashes with broken SVG file

After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.

Bug 313397 - crashes with broken SVG file


Summary:	crashes with broken SVG file


Status:	RESOLVED FIXED

Product:	eog
Classification:	Core
Component:	image viewer
Version:	2.11.x
Hardware:	Other Linux

Importance:	High critical
Target Milestone:	---
Assigned To:	EOG Maintainers
QA Contact:	EOG Maintainers

URL:
Whiteboard:

Duplicates:	156274 300072 305886 (view as bug list)
Depends on:
Blocks:

Reported:	2005-08-13 16:18 UTC by Guilherme de Siqueira Pastore
Modified:	2005-10-24 21:51 UTC

See Also:
GNOME target:	---
GNOME version:	2.11/2.12

Attachments
Broken SVG that causes eog to crash (1.34 KB, image/svg+xml) 2005-08-13 16:19 UTC, Guilherme de Siqueira Pastore		Details
Fixes the broken SVG crash. (1.98 KB, patch) 2005-09-06 18:56 UTC, Lucas Rocha	none	Details \| Review
Improved patch. (565 bytes, patch) 2005-09-30 02:43 UTC, Lucas Rocha	none	Details \| Review

Description Guilherme de Siqueira Pastore 2005-08-13 16:18:18 UTC

Distribution/Version: Debian

eog uglily crashes or freezes with an improper/broken SVG file, as reported on
Debian bug #322879 - http://bugs.debian.org/322879. Of course, I don't expect it
to work, but showing a friendly dialog telling the user what went wrong is
surely better than crashing, etc.

I'll attach the example file for convenience.

Thanks!

Comment 1 Guilherme de Siqueira Pastore 2005-08-13 16:19:08 UTC

Created attachment 50652 [details]
Broken SVG that causes eog to crash

Comment 2 Ruben Vermeersch 2005-08-18 12:36:07 UTC

Reproducable, though not able to create a decent backtrace because of stripped
libraries:

ruben@tokyo:~/Desktop $ eog broken.svg 

(eog:12184): librsvg-WARNING **: rsvg_start_svg: width too large

(eog:12184): GLib-GObject-CRITICAL **: g_object_ref: assertion `G_IS_OBJECT
(object)' failed

Eog-ERROR **: file eog-image.c: line 843 (real_image_load): assertion failed:
(image != NULL)
aborting...

Comment 3 Sebastien Bacher 2005-08-18 13:22:47 UTC

backtrace with 2.11.91:

(eog:32423): librsvg-WARNING **: rsvg_start_svg: width too large

Eog-ERROR **: file eog-image.c: line 813 (eog_image_real_load): assertion
failed: (priv->image != NULL)
aborting...

Program received signal SIGABRT, Aborted.

+ Trace 62522

Thread NaN (LWP 32426)

#0 __kernel_vsyscall
#1 raise
from /lib/tls/i686/cmov/libc.so.6
#2 abort
from /lib/tls/i686/cmov/libc.so.6
#3 IA__g_logv
at gmessages.c line 497
#4 IA__g_log
at gmessages.c line 517
#5 IA__g_assert_warning
at gmessages.c line 552
#6 eog_image_real_load
at eog-image.c line 813
#7 eog_image_load
at eog-image.c line 928
#8 job_prepare_model_do
at main.c line 456
#9 eog_job_call_action
at eog-job.c line 385
#10 thread_start_func
at eog-job-manager.c line 85
#11 g_thread_create_proxy
at gthread.c line 564
#12 start_thread
from /lib/tls/i686/cmov/libpthread.so.0
#13 clone
from /lib/tls/i686/cmov/libc.so.6

Comment 4 Lucas Rocha 2005-09-06 18:56:42 UTC

Created attachment 51884 [details] [review]
Fixes the broken SVG crash.

Comment 5 Lucas Rocha 2005-09-30 02:43:27 UTC

Created attachment 52839 [details] [review]
Improved patch.

Comment 6 Tim Gerla 2005-10-07 14:00:24 UTC

Applied, thanks!

Comment 7 Lucas Rocha 2005-10-18 02:32:30 UTC

*** Bug 300072 has been marked as a duplicate of this bug. ***

Comment 8 Lucas Rocha 2005-10-18 02:33:56 UTC

*** Bug 156274 has been marked as a duplicate of this bug. ***

Comment 9 Lucas Rocha 2005-10-24 21:51:27 UTC

*** Bug 305886 has been marked as a duplicate of this bug. ***