After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313326 - Default Profile changes when editing profiles
Default Profile changes when editing profiles
Status: RESOLVED FIXED
Product: gnome-terminal
Classification: Core
Component: general
2.11.x
Other All
: High minor
: ---
Assigned To: GNOME Terminal Maintainers
GNOME Terminal Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-12 13:27 UTC by Chris Heath
Modified: 2005-08-19 20:50 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10

Attachments
Proposed patch (1.09 KB, patch)
2005-08-13 03:58 UTC, Chris Heath 		none Details | Review

Description Chris Heath 2005-08-12 13:27:23 UTC 
Please describe the problem:
After editing a profile, the default profile shown in the Manage Profiles window
resets to the first profile in the list.

Steps to reproduce:
1. Suppose you have 3 profiles, A, B, and C.
2. Edit->Profiles...
3. Select B as your default profile
4. Select Profile C in the list and click the Edit button.
5. Click Close on the edit window.


Actual results:
The default profile changes to A.

Expected results:
The default profile stays at B.

Does this happen every time?
Yes.

Other information:
Comment 1 Chris Heath 2005-08-13 03:58:28 UTC 
Created attachment 50636 [details] [review]
Proposed patch

This one is rather subtle!

Calling gtk_option_menu_set_menu then gtk_option_menu_set_history causes the
option menu's change notification to fire twice.  We must call
update_default_profile on each change, otherwise the second time it thinks
nothing changed.
Comment 2 Guillaume Desmottes 2005-08-13 10:30:53 UTC 
Thanks for bug report!
Priority high due to the patch.
Comment 3 Kjartan Maraas 2005-08-15 13:51:06 UTC 
I'm going to go through gnome-terminal and vte patches later today and make sure
we get some of these fixes in before the next release.
Comment 4 Kjartan Maraas 2005-08-19 20:50:55 UTC 
Commited. Thanks