GNOME Bugzilla – Bug 313172
Multiple glitches in Trash
Last modified: 2009-02-21 14:57:43 UTC
Please describe the problem: There are many "cosmetic" problems in the Trash. The first one is being the properties window, is it really needed to have a Properties page?, ok, it might be justified, but a Notes page?. (See attachment number one) Secondly, is that the properties window doesnt even work right (See attachment number two) Third, is that the nautilus File menu doesnt display the Property page menuitem as sensitive. (See attachment number three) I guess this opens a discussion about the points described above. Wasn't it going to be replaced by the trash applet? Steps to reproduce: Actual results: Expected results: Does this happen every time? Other information:
Created attachment 50543 [details] Number one
Created attachment 50544 [details] Number three, nautilus
Created attachment 50545 [details] Extra missing icon
Sorry, in the report, attachment one and two, are the same, (See attachment number one). The second attachment should be (Extra missing icon), and it is about the missing icon and text in the empty trash dialog.
Thanks for your bug report! > is it really needed to have a Properties page You're raising a good question. I think it is considered useful to see the overall amount of space used by items in trash. > but a Notes page? Does it do any harm? > Third, is that the nautilus File menu doesnt display the Property page menuitem as sensitive. Well, the Nautilus maintainers think that the actions in the "File" menu should just refer to the container (i.e. the trash) contents, not to the container itself. This means consequently that the "Properties" item is only meant to be used for trash contents. In Nautilus 2.11, you can however use the context menu on the "Location:" label (navigational) or the location button (spatial) to bring up a menu with container-related actions. I agree with you that the "Empty Trash" dialog button sould contain an GTK_STOCK_CLEAR pixbuf.
Created attachment 59166 [details] [review] This patch adds the icon to the "Empty Trash Button". This patch adds the stock GTK_STOCK_CLEAR to the Empty Trash button on the dialog which confirms the emptying of the trash. This at least partially fixes the problems described.
Created attachment 59168 [details] [review] A patch to remove the "Volume:" and "Free space:" items from the properties page. A patch to remove the "Volume:" and "Free space:" items from the properties page. I agree with the reporter, this are not necessary. The trash is a merged directory which shows items which are possibly located on multiple volumes which each have their own free-space values, so showing them in the Trash directory properties page is un-necessary, IMHO.
It took 6 months to do a simple thing, but it was done. Good job. I believe this wont even make it for 2.14 am I right?
Also I just realized that on .12, the MenuItem for "Empty Trash" also needs a STOCK_CLEAR, and the "Move to Trash, and Delete" MenuItems should outright be taken out, not set unsensitive. I agree with Lakin on the properties page, it is unnecesary.
Please update to HEAD.
Updated.
The commit of Revision 14188 [1] obsoletes the need for the latter patch, but the former one might still be valid (though it doesn't apply anymore, apparently for a long time). Setting status on these. [1]: http://svn.gnome.org/viewvc/nautilus?view=revision&revision=14188
Is this still an issue in 2.22? Trash handling has been rewritten.
I assume it's not. Please reopen if this is still an issue!