After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 313025 - avoid horizontal bar in icon views
avoid horizontal bar in icon views
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Views: Icon View
2.12.x
Other All
: Normal minor
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-08-09 17:07 UTC by Baptiste Mille-Mathias
Modified: 2012-09-19 03:17 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
an example (30.47 KB, image/png)
2005-08-09 17:16 UTC, Baptiste Mille-Mathias
  Details
Proposed patch (1.05 KB, patch)
2005-09-10 22:48 UTC, Christian Neumair
none Details | Review
Proposed patch #2 (1.19 KB, patch)
2005-09-20 16:39 UTC, Christian Neumair
none Details | Review
a screenshot (50.12 KB, image/png)
2006-01-28 17:25 UTC, Baptiste Mille-Mathias
  Details

Description Baptiste Mille-Mathias 2005-08-09 17:07:16 UTC
Hello,

One thing is irritating in icons view, this the way nautilus compute and display
icons in icons view. I means Nautilus should avoid to diplay icons over the
window border, because the horizontal bar appears and disappears, it is confusing.
Nautilus should draw the icon to the following lines.

I hope my request is understandable, I will attach a screenshot.

(I didn't find a duplicate bug, sorry if I miss it)
Comment 1 Baptiste Mille-Mathias 2005-08-09 17:16:37 UTC
Created attachment 50480 [details]
an example

In this example, Nautilus displays a horizontal bar only for folder "PHP &
MySQL" (which is display entirely.
I assume Nautilus probably doesn't calcute weel the space used for display the
icon + test.
I would like Nautilus displays the folder to the line below.
Comment 2 Teppo Turtiainen 2005-08-10 05:32:34 UTC
Then what would happen when the user moves a file so close to the egde of the
nautilus window that the name of the file overlaps with the edge?
Comment 3 Baptiste Mille-Mathias 2005-08-10 08:36:31 UTC
Hello Teppo

I assume that Nautilus should move the file/folder to the next line, at least in
automatic layout, I don't really see the problem.
Comment 4 Teppo Turtiainen 2005-08-10 16:19:50 UTC
Oh, I thought you were using manual layout. I got confused by the compact layout
and text besides icons combination. Confirming.
Comment 5 Christian Neumair 2005-09-10 22:48:07 UTC
Created attachment 52069 [details] [review]
Proposed patch

I've also submitted the attached patch to the nautilus mailing list [1] for
review.

[1] http://mail.gnome.org/archives/nautilus-list/2005-September/msg00098.html
Comment 6 Christian Neumair 2005-09-20 16:39:08 UTC
Created attachment 52436 [details] [review]
Proposed patch #2

Alex didn't like the first patch, since it ensured a margin of 8 px on the
right side which he considered too much whitespace. This one makes Nautilus
only wrap if the right edge of the window is small enough to "touch" the right
edge of the rightmost icon.
Comment 7 Christian Neumair 2005-09-30 15:11:59 UTC
I've committed a slightly modified variant that also fixes the issue for the
text besides icon layout.
Comment 8 Baptiste Mille-Mathias 2005-10-19 19:47:31 UTC
Hello Christian,

The behaviour was improved but I saw this bug again, is it possible to make it
better ?

I reopen this bug, waiting for manny comments.
Comment 9 Baptiste Mille-Mathias 2006-01-28 17:25:16 UTC
Created attachment 58270 [details]
a screenshot

Just to have a  shot of the bug still exist
Comment 10 Baptiste Mille-Mathias 2008-03-26 18:35:30 UTC
Hey Christian,

You're kind enough to almost fix this bug; but it still appears (but not much as before); could give me direction where to look at if I can fix that with my small knowledge ?

Thanks
Comment 11 William Jon McCann 2012-09-19 03:17:30 UTC
I don't think this problem can happen anymore. Please reopen if it is still an issue.