After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312803 - crash on print to file
crash on print to file
Status: RESOLVED FIXED
Product: gnome-print
Classification: Deprecated
Component: general
2.10.x
Other Linux
: High critical
: ---
Assigned To: Jody Goldberg
Marco Pesenti Gritti
Depends on:
Blocks:
 
 
Reported: 2005-08-07 14:57 UTC by Christian Persch
Modified: 2005-09-22 19:28 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.47 KB, patch)
2005-08-28 10:40 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2005-08-07 14:57:59 UTC 



+
Trace
    62264






    

  • 
#7
<signal handler called>

    • 

  • 
#8
fclose

    
                from
                /lib/tls/i686/cmov/libc.so.6

    

    • 

  • 
#9
gnome_print_transport_new

    
                from
                /usr/lib/libgnomeprint-2-2.so.0

    

    • 

  • 
#10
gnome_print_transport_print_file

    
                from
                /usr/lib/libgnomeprint-2-2.so.0

    

    • 

  • 
#11
gnome_print_job_print

    
                from
                /usr/lib/libgnomeprint-2-2.so.0

    

    • 

  • 
#12
ephy_print_do_print_idle_cb

    
                at ../../embed/print-dialog.c
                  line
                  316

    

    • 

  • 
#13
g_idle_dispatch

    
                at gmain.c
                  line
                  3813

    

    • 

  • 
#14
g_main_dispatch

    
                at gmain.c
                  line
                  1934

    

    • 

  • 
#15
g_main_context_dispatch

    
                at gmain.c
                  line
                  2484

    

    • 

  • 
#16
g_main_context_iterate

    
                at gmain.c
                  line
                  2565

    

    • 

  • 
#17
g_main_loop_run

    
                at gmain.c
                  line
                  2769

    

    • 

  • 
#18
IA__gtk_main

    
                at gtkmain.c
                  line
                  963

    

    • 

  • 
#19
main

    
                at ../../src/ephy-main.c
                  line
                  312

    

    • 













Comment 1


Christian Persch





          2005-08-08 10:39:30 UTC
        



Re-assigning to gnome-print.






Comment 2


Christian Kirbach





          2005-08-09 14:14:02 UTC
        



unique stack trace.






Comment 3


Christian Persch





          2005-08-28 10:40:23 UTC
        



Created attachment 51453 [details] [review]
proposed patch

Don't fclose(NULL), it'll crash.

There's more strange code in gnome_print_transport_real_print_file: in case
gnome_print_transport_write fails, it bails out without closing the print
transport with gnome_print_transport_close; couldn't that leak resources
potentially associated with the print transport? Anyway I don't know enough
about that code, so only fixing the obvious problem with fclose.






Comment 4


Jody Goldberg





          2005-09-22 19:28:44 UTC
        



Thanks for the patch.
I've also fixed the oddity of returning a byte count as a status.