Created attachment 50326 [details] [review]
patch mostly from gcursor

Copy/Paste gcursor's function and add an "install Theme" button. I works not
with all tarballs but it's not the installer's fault but tarball's.

Confirming so developers can look at the patch.

Thanks for your patch. Ccing Sven who works on this

reading your patch leaves two questions for me:

1. why did you touch populate_tree_model?
2. why are you checking for GTK+ 2.4 (don't we depend on 2.6 or bigger?)

1. because populate_tree_model() doesn't need to know the selection. he can
found it himself. And that's important because extract_theme() doesn't know the
selection (or can found but with duplicate code)

2. Strange... That's the original code in gcursor. I fixed this... maybe a
attached the wrong patch. I'll correct it asap.

Created attachment 50805 [details] [review]
no more 2.4.0 check

Thanks for your work on this patch. I'm not convinced by the current version. It
should use the same dialog as the theme-manager capplet and not require
file-roller to install the files imho.

Two other things:

1. Native speakers:
"Select a xcursor theme" shouldn't this be "an xcursor theme" as its pronounced
"an ixcursor theme"? (like "an hour")

2. UI interactivity:
We should definitely extract the package synchronously (the "right" way is to to
it asynchronously and have watches - via gnomevfs - that look for changes in the
interesting directories)

Will be "Install Theme" button to install a tarball in ~/.icons available in GNOME 2.14 ?

To fix this bug we'll need:

1. a common way to install themes/cursors for the theme and the mouse capplet

2. patches that make both the theme and the mouse capplet use this code

Does this still apply since gnome-mouse-property cursor theme is now merged in appearance-properties ?

Étienne.

As cursor themes are technically the same as icon themes and icon themes are easily installable in the appearance capplet, installing cursor themes shouldn't be a problem anymore. But I don't have a packaged icon theme to test (icon themes work fine). If somebody has a cursor theme pacakage, it would be cool if he/she could test it by dropping that package into the appearance capplet. If someone can confirm that it works, we can mark this bug as FIXED.

http://www.kde-look.org has scores of cursor themes.

(In reply to comment #13)
> http://www.kde-look.org has scores of cursor themes.
> 

Okay I tried it with a cursor theme from there. This works in principle; unfortunately, the cursor theme list doesn't seem to be upgraded after installing cursor themes, so they only appear in the list after the appearance capplet is restarted. This needs to be fixed.

Fixed in 2.21.1.