GNOME Bugzilla – Bug 312775
HAL build broken on Slackware (with patch!)
Last modified: 2005-10-24 05:27:13 UTC
Please describe the problem: When compiling GARNOME, when you get to Nautilus CD thinger, hal is required, and when GARNOME tries to build HAL: checking for BLKGETSIZE64... no configure: error: BLKGETSIZE64 is not defined make[3]: *** [configure-work/main.d/hal-0.5.3/configure] Error 1 make[3]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal' make[2]: *** [../../freedesktop/hal/cookies/main.d/install] Error 2 make[2]: Leaving directory `/home/source/garnome-2.11-20050804.1745/desktop/nautilus-cd-burner' make[1]: *** [../../desktop/nautilus-cd-burner/cookies/main.d/install] Error 2 make[1]: Leaving directory `/home/source/garnome-2.11-20050804.1745/desktop/gnome-media' make: *** [paranoid-install] Error 2 There is an out-dated patch in the FAQ: http://cipherfunk.org/garnome/faq.html for Slackware, which I have updated such that it works again (on my system at least). Steps to reproduce: 1. Install Slackware 2. Run GARNOME 3. arrive at HAL . . . Actual results: You receive an error message when the test for BLKGETSIZE64 fails :| Expected results: Either BLKGETSIZE64 test would be skipped (like the patch does (though ideally, only for Slackware)) :| Does this happen every time? Aye. Other information: Patch immiment.
Created attachment 50325 [details] [review] Updates Slackware-HAL patch to enable GARNOME's buliding I suppose some sort of check on whether the system is Slackware or not (and if so, define the broken system bits ourselves) would be better, but this is my first patch ever, and at least the build succeeds now (until the next error).
Later on, this appears: probe-input.c: In function `main': probe-input.c:133: error: storage size of `id' isn't known probe-input.c:131: warning: unused variable `conn' probe-input.c:133: warning: unused variable `id' make[9]: *** [probe-input.o] Error 1 make[9]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal/work/main.d/hal-0.5.3/hald/linux2/probing' make[8]: *** [all-recursive] Error 1 make[8]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal/work/main.d/hal-0.5.3/hald/linux2' make[7]: *** [all-recursive] Error 1 make[7]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal/work/main.d/hal-0.5.3/hald' make[6]: *** [all] Error 2 make[6]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal/work/main.d/hal-0.5.3/hald' make[5]: *** [all-recursive] Error 1 make[5]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal/work/main.d/hal-0.5.3' make[4]: *** [all] Error 2 make[4]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal/work/main.d/hal-0.5.3' make[3]: *** [build-work/main.d/hal-0.5.3/Makefile] Error 2 make[3]: Leaving directory `/home/source/garnome-2.11-20050804.1745/freedesktop/hal' make[2]: *** [../../freedesktop/hal/cookies/main.d/install] Error 2 make[2]: Leaving directory `/home/source/garnome-2.11-20050804.1745/desktop/nautilus-cd-burner' make[1]: *** [../../desktop/nautilus-cd-burner/cookies/main.d/install] Error 2 make[1]: Leaving directory `/home/source/garnome-2.11-20050804.1745/desktop/gnome-media' make: *** [paranoid-install] Error 2 I will account for it in an updated patch later to-night.
Created attachment 50365 [details] [review] Update to the Slackware patch in the GARNOME FAQ This patch comments out an unused variable in probe-input.c and defines a structure input_id whose size is reported as 'unknown' on Slackware. The definition was borrowed from a Ubuntu Linux install. There is a third, docbook problem with Slackware that I am encountering which this does not yet address, but can be worked around by cleaning out the actually building in the erroneous folder's Makefile :|
*** Bug 316594 has been marked as a duplicate of this bug. ***
*** Bug 316598 has been marked as a duplicate of this bug. ***
This is a Slackware bug.
Infact, the updated patch is included with GARNOME 2.12.1 and above, you just need to uncomment it in the freedesktop/hal/Makefile before starting your build. Still technically an upstream bug though :)