After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312687 - notification area "space leakage"
notification area "space leakage"
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Widget: Other
2.7.x
Other other
: Normal major
: ---
Assigned To: gtk-bugs
gtk-bugs
: 304634 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-08-05 15:05 UTC by Gábor Lénárt
Modified: 2006-02-11 11:06 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
screenshot showing the bug (3.06 KB, image/png)
2005-08-09 14:35 UTC, Vincent Noel
  Details
gtk-fix-plug-removed-emission.patch (1.11 KB, patch)
2005-08-09 15:34 UTC, Mark McLoughlin
none Details | Review
Screenshot showing this problem again (6.74 KB, image/png)
2006-02-11 11:05 UTC, James Ogley
  Details

Description Gábor Lénárt 2005-08-05 15:05:54 UTC
Distribution: Ubuntu 5.10 (breezy)
Package: gnome-panel
Severity: enhancement
Version: GNOME2.11.90 unspecified
Gnome-Distributor: Ubuntu
Synopsis: notification area "space leakage"
Bugzilla-Product: gnome-panel
Bugzilla-Component: Notification Area Applet
Bugzilla-Version: unspecified
Description:
Please describe your feature request:

Maybe this is not a feature request though :) After some usage of gnome
desktop notification area "leaks", I mean the firstly created icon in
notification areas is shifted right, and huge empty space is before it.
Even is grows ... If I quit from application whose has that icon we're
talking about and relaunch it that everything went ok. So besides for my
very poor English I would like to use a feature to "collapse empty
space" in notification area.




------- Bug moved to this database by unknown@gnome.bugs 2005-08-05 15:05 UTC -------

Comment 1 Vincent Noel 2005-08-09 14:35:31 UTC
Created attachment 50470 [details]
screenshot showing the bug

I'm seeing this too.
After a few days of use, the notification area becomes huge. I have to restart
it to get the space back.
On the screenshot, the empty space between the gaim icon and tomboy (applet) is
the notification area. If I right-click on it I get the notification area
applet popup menu.
Comment 2 Vincent Noel 2005-08-09 14:36:39 UTC
I'm upping the severity because it's a very visible bug.
Comment 3 Mark McLoughlin 2005-08-09 15:33:09 UTC
Turns out to be a gtk+ buglet introduced by Tor's porting GtkPlug/GtkSocket to
windows.

Attaching patch
Comment 4 Mark McLoughlin 2005-08-09 15:34:43 UTC
Created attachment 50473 [details] [review]
gtk-fix-plug-removed-emission.patch

Basically, its just confusion around the fact that g_signal_emit_by_name()
doesn't take a "detail" arg - people pass in zero out of habit
Comment 5 Mark McLoughlin 2005-08-09 15:36:17 UTC
(I guess I should explain why this causes the bug)

When the plug goes away, the "plug-removed" signal emission fails, the widget
never gets destroyed and we're left with lots of stale 1x1 widgets
Comment 6 Mark McLoughlin 2005-08-09 16:30:14 UTC
2005-08-09  Mark McLoughlin  <mark@skynet.ie>

        Fixes "notification area leaks space" (bug #312687)

        * gtk/gtksocket-x11.c: (_gtk_socket_windowing_filter_func):
          gtk/gtkplug.c: (_gtk_plug_add_to_socket): don't pass a
        detail to g_signal_emit_by_name()

Comment 7 Tor Lillqvist 2005-08-09 17:00:33 UTC
Thanks. Now that I look at the attached patch, I recall I was in fact wondering
a bit how to convert the original:

	    g_signal_emit (widget, socket_signals[PLUG_REMOVED], 0, &result);

into a g_signal_emit_by_name call. Unfortunately I got it wrong.
Comment 8 Mark McLoughlin 2005-08-14 10:27:56 UTC
*** Bug 304634 has been marked as a duplicate of this bug. ***
Comment 9 James Ogley 2006-02-11 11:05:25 UTC
Created attachment 59129 [details]
Screenshot showing this problem again

I'm still seeing this bug in GTK+ 2.8.10.