GNOME Bugzilla – Bug 312545
replying to attached messges doesn't quote any content
Last modified: 2013-09-13 00:46:47 UTC
Please describe the problem: If you have a message attached to a message, when you reply to it, it no longer quotes the content of the attached message. Because the attachment-bar code modifies the message parts - by adding filenames - the 'is this an attachment so shouldn't be quoted' logic doesn't quote the content. Steps to reproduce: forward a message to yourself, then reply to the message attachment using the popup menu. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 50446 [details] [review] Proposed Patch
dont check before calling g_free, it already does it, you do this in several places: + if (new->file_name) + g_free (new->file_name); otherwise: no changelogs. please re-submit a new patch.
Created attachment 50479 [details] [review] reworked patch I have done the change. Ill add the changelog while commiting.
sorry, changelogs are required as part of teh patch
Created attachment 50498 [details] [review] reworked patch with changelogs
I dont know how you generated it but it wont apply. make sure you diff from the root of the source tree. e.g. cvs diff mail widgets/misc > 312545.diff
Created attachment 50553 [details] [review] this should apply
thanks, seems to do the job, please commit. Can you look at fixing these warnings sometime? \ doesn't escape %, PLEASE read the printf man page ... e-attachment-bar.c: In function `update_remote_file': e-attachment-bar.c:432: warning: unknown conversion type character `)' in format base = g_path_get_basename(attachment->file_name); msg = g_strdup_printf("%s (%d\%)", base, attachment->percentage); g_free(base); and: e-attachment.c: In function `download_to_local_path': e-attachment.c:365: warning: passing arg 8 of `gnome_vfs_async_xfer' from incompatible pointer type e-attachment.c:721:2: warning: #warning "signal connect while alive"
committed to head
verified using evolution-2.4.0.