GNOME Bugzilla – Bug 312397
Forward Of Message Displays Wrong Names In Comments
Last modified: 2005-08-08 09:45:09 UTC
Please describe the problem: I'm sending a screenshot of a bug when forwarding a message. The message bounced back and forth between two people and that worked when using "Reply", but when you "Forward" and have your style set to "Attachment" it puts in the name of the Forwarder as making the last comment immediately before the forward. In the shot, the account "Teachers" sent something to me, and I forwarded it back to them and it appears that I've made the last two comments, instead of just the last one. This is causing problems with legal documents and messages being sent around our organization. Steps to reproduce: 1. 2. 3. Actual results: Expected results: Does this happen every time? Other information:
Created attachment 50145 [details] Green circle is ok, red section is displaying the wrong person as having made the comment
dave, the comment of the form "On <Day>. <Date> at <Time>, <User> wrote:" is present only when a mail is replied to. In the screenshot the comment "On Tue ....... Dave Richards wrote:" is from the previous reply you probably made.
That is correct, let me step you through exactly how to recreate this bug. Configure two Evolution users in Text mode (not-HTML) and forward style of attachment. Step 1) User 1 send email to User 2 Step 2) User 2 reply to message back to User 1, works fine. Step 3) User 1 forwards message to User 2 (in attachment mode), works. Step 4) User 2 Reply to the message, the last On <Day> header is wrong for Step #2 Attaching another screenshot, you can see the flow better on this one.
Created attachment 50169 [details] Better shot of the bug, reply after forward creates wrong message.
the reply generating engine is using the same formatter for the toplevel message as any attachments, so they all get the same attribution.
Created attachment 50212 [details] how proposed fix looks
Created attachment 50213 [details] [review] a fix the fix just ensures that the attribution only occurs at the very top of the message. the 'attachment' thing isn't very obvious though, maybe it needs some []'s or something?
It would be nice to have the attribution added to a forwarded message in the same way it does in a reply so that the last comment is marked and everyone knows who made the statement. We have a high number of messages that bounce around between about 10 people at a time with everyone adding legal type comments. To whomever commits to 2.2, please make sure this is pushed into 2.3 as well. thanks
i've committed this patch, to 2.3. i will do 2.2 shortly. attribution doesn't make sense, you're adding something to the message which wasn't there, whereas an attribution may already be there in that message. Maybe it should display some headers, like forwarding inline does. e.g. from/to/subject? That is exactly what gmail does - displays and replies to it it as it if were just forwarded inline. i'll attach another patch/screenshot
Created attachment 50253 [details] [review] futher changes to improve usability
Created attachment 50254 [details] updated screenshot
(the attachment thing is probably annoying but a bit harder to remove)
committed to 2.3. These patches wont apply to 2.2 though, so attaching a separate patch for that. I can't test this patch easily - camel versioning is broken, so you can't work on two installed development environments simultaneously ...
Created attachment 50366 [details] [review] slightly different patch for 2.10
Created attachment 50375 [details] [review] slightly different patch for 2.10
ok, all in