After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312160 - Jump To button opens file browser instead of spatial folder
Jump To button opens file browser instead of spatial folder
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: Bookmarks
2.11.x
Other All
: Normal normal
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-31 20:26 UTC by Jaap A. Haitsma
Modified: 2005-08-05 23:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12

Attachments
patch (4.45 KB, patch)
2005-08-02 07:13 UTC, Jaap A. Haitsma 		committed Details | Review

Description Jaap A. Haitsma 2005-07-31 20:26:20 UTC 
Since the default of nautilus is spatial I'd expect that a spatial folder would open
Comment 1 Sebastien Bacher 2005-08-01 07:45:00 UTC 
Thanks for your bug. Where is this button?
Comment 2 Christian Neumair 2005-08-01 08:35:23 UTC 
In the "Edit Bookmarks" dialog.
Comment 3 Christian Neumair 2005-08-01 08:44:22 UTC 
This relevant code is in src/nautilus-bookmark-window.c:open_selected_bookmark.
Comment 4 Jaap A. Haitsma 2005-08-01 08:46:53 UTC 
Christian. I don't know if you are already writing a patch for it. You seem to
be faster then lightning in producing patches ;-)
Just wanted to let you know that I'm  (also) working on a patch.
Comment 5 Christian Neumair 2005-08-01 09:01:37 UTC 
Feel free to come up with a reasonable patch. I appreciate your involvement :).
Developers, developers, developers, ... . Whatever.
Comment 6 Jaap A. Haitsma 2005-08-02 07:13:36 UTC 
Created attachment 50111 [details] [review]
patch

This patch respects all the user settings about navigation/spatial windows. It
looks at what kind of window opened the bookmarks window and then opens the
same kind of window.

Furthermore it also solves a bug. In the original code a new nautilus
application was made (nautilus_application_new) this generated the following

** (nautilus:16176): CRITICAL **: nautilus_view_factory_register: assertion
`nautilus_view_factory_lookup (view_info->id) == NULL' failed

** (nautilus:16176): CRITICAL **: nautilus_view_factory_register: assertion
`nautilus_view_factory_lookup (view_info->id) == NULL' failed

** (nautilus:16176): CRITICAL **: nautilus_view_factory_register: assertion
`nautilus_view_factory_lookup (view_info->id) == NULL' failed
Comment 7 Christian Neumair 2005-08-05 23:28:09 UTC 
According to [1], a slightly modfied version of that patch has been committed.

[1] http://mail.gnome.org/archives/nautilus-list/2005-August/msg00058.html