GNOME Bugzilla – Bug 312126
libedataserverui uses libgnome for no good reason
Last modified: 2005-10-14 13:27:21 UTC
libedataserver[ui] uses libgnome when it could use GLib. Attaching a patch to replace the libgnome functions in the libedataserver[ui] tests with GLib functions, and to update the build system so that the server binary depends on libgnome.
Created attachment 50011 [details] [review] Patch to remove libgnome from libedataserver Note that this patch isn't just cleaning up deprecated APIs, but it means that a pure-GTK application can be written which uses libedataserver, without depending on libgnome.
well harish?
Created attachment 50776 [details] [review] Revised patch New patch: configure.in | 20 ++++----- libedataserver/libedataserver.pc.in | 7 --- libedataserver/test-source-list.c | 71 ++++++++++---------------------- libedataserverui/ChangeLog | 6 ++ libedataserverui/libedataserverui.pc.in | 7 --- libedataserverui/test-contact-store.c | 12 ----- libedataserverui/test-name-selector.c | 16 +------ src/Makefile.am | 4 - 8 files changed, 52 insertions(+), 91 deletions(-) This also cleans up configure.in a little and uses @API_VERSION@ instead of hard-coding 1.2 in the pkgconfig files.
Created attachment 51860 [details] [review] Revised patch New patch against e-d-s 1.4.0: ChangeLog | 7 +++ configure.in | 20 ++++----- libedataserver/libedataserver.pc.in | 7 --- libedataserver/test-source-list.c | 71 ++++++++++---------------------- libedataserverui/ChangeLog | 6 ++ libedataserverui/libedataserverui.pc.in | 7 --- libedataserverui/test-contact-store.c | 12 ----- libedataserverui/test-name-selector.c | 16 +------ src/Makefile.am | 4 - 9 files changed, 59 insertions(+), 91 deletions(-)
Created attachment 53456 [details] [review] Revised patch
Looks good. Please commit this to HEAD.
Committed to head, thanks.
BTW, what tool produces those cool diff summaries?
It's from diffstat.