After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312114 - [PATCH]gnomevfssrc unneccessarily registers callbacks with gnome-vfs in some cases
[PATCH]gnomevfssrc unneccessarily registers callbacks with gnome-vfs in some ...
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-plugins
0.8.10
Other All
: Normal normal
: 0.8.12
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-31 06:39 UTC by Charles Schmidt
Modified: 2006-01-27 09:19 UTC
See Also:
GNOME target: ---
GNOME version: 2.9/2.10


Attachments
patch to gstgnomevfssrc.c (985 bytes, patch)
2005-07-31 06:40 UTC, Charles Schmidt
committed Details | Review

Description Charles Schmidt 2005-07-31 06:39:47 UTC
Please describe the problem:
For iradio metadata information gnomevfssrc registers callbacks with gnome-vfs
to send & recieve additional headers.  If gnomevfssrc is NOT in iradio mode, it
still registers this callbacks, which interfere with other applications that may
need to send & recieve additional headers.

I am adding iTunes Music Sharing support to Rhythmbox.  The communcation is done
via HTTP 1.1, and so for getting music files I use an http:// uri passed to a
gstreamer playbin element.  However, I need to send additional headers (a hash
of the file path for authentication purposes) so that iTunes will actually send
the file.  But, since gnomevfssrc /always/ registers the send/recieve callbacks
(and strangely enough it seems gnome-vfs can only have 1 set registered), my
callbacks are never run.  Since this is /definitly/ not iradio mode, the
callbacks do not need to be registered in gnomevfssrc.

I have a patch against gst-plugins 0.8.10, and can remake it against CVS (the
0.8 branch?, so that this can get into Rhythmbox before RB works with 0.9?) if
needed.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Charles Schmidt 2005-07-31 06:40:15 UTC
Created attachment 50004 [details] [review]
patch to gstgnomevfssrc.c
Comment 2 Christian Kirbach 2005-08-01 08:35:01 UTC
thanks for sending in.

confirming so maintainers can have a look at it
Comment 3 Colin Walters 2005-08-03 20:53:59 UTC
Patch looks reasonable to me (I wrote most of the iradio-mode support).
Comment 4 Luca Ognibene 2005-09-17 10:28:54 UTC
committed to 0.8 cvs, thanks!
Comment 5 Alex Lancaster 2006-01-27 09:19:36 UTC
Change patch status to committed.