After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 312110 - [enh] improved tray icon usability
[enh] improved tray icon usability
Status: RESOLVED FIXED
Product: muine
Classification: Other
Component: interface
trunk
Other All
: Normal enhancement
: ---
Assigned To: Muine Maintainers
Muine Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-31 03:30 UTC by Allison Karlitskaya (desrt)
Modified: 2008-09-28 01:05 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
the patch for the improved interface (1.97 KB, patch)
2005-07-31 03:43 UTC, Allison Karlitskaya (desrt)
rejected Details | Review
20_desrt_trayicon_behaviour.patch from ubuntu muine package (2.67 KB, patch)
2007-06-19 22:28 UTC, Allison Karlitskaya (desrt)
committed Details | Review

Description Allison Karlitskaya (desrt) 2005-07-31 03:30:31 UTC
Myself and some friends have been using a modified version of the Muine tray
icon plugin for a while now.  We all believe that it's more useful than the
official version.

Semantics are:
Left click: show/hide main window.
Middle click: play/pause
Right click: pop up context menu

Additionally, a "quit" item is added to the context menu.

Also, when the close button is clicked on the playlist dialog, it is merely
dismissed (as opposed to closing the entire program).  I know that this feature
was rejected before, but now that the tray icon is a separate plugin that is
only installed if the user explicitly wants it, this behaviour is a lot more
reasonable.

I'll clean up the version that I've been using and generate a diff against CVS HEAD.
Comment 1 Allison Karlitskaya (desrt) 2005-07-31 03:43:04 UTC
Created attachment 49997 [details] [review]
the patch for the improved interface
Comment 2 Jorn Baayen 2005-07-31 06:09:07 UTC
This wont go into main, but feel free to publish your own plugin. 
Comment 3 Wouter Bolsterlee (uws) 2006-11-14 14:15:25 UTC
Reopening because some people like to discuss this 'feature'... :)
Comment 4 Allison Karlitskaya (desrt) 2007-06-19 22:28:27 UTC
Created attachment 90306 [details] [review]
20_desrt_trayicon_behaviour.patch from ubuntu muine package

this is the patch that ubuntu feisty is currently carrying.

i wrote it and i think bhale has tweaked it a few times to track muine changes.
Comment 5 Diego Escalante Urrelo (not reading bugmail) 2007-08-06 11:54:16 UTC
I support the original idea of the patch.
Comment 6 Wouter Bolsterlee (uws) 2008-09-22 16:13:48 UTC
Ok, I like the behaviour described by the original reporter. If nobody complains I'd suggest that desrt sneaks his patch in when nobody looks and then closes this bug report (and *finally* be done with it...).
Comment 7 Luis Medinas 2008-09-28 01:05:54 UTC
Finally commited to svn trunk!!
Thanks for the patch!

2008-09-28  Luis Medinas  <lmedinas@gnome.org>

            * plugins/TrayIcon.cs:
            * plugins/TrayIcon.xml:

            Improve tray icon usuability. Fixes bgo #312110 and #378019.
            Patch from Ryan Lortie (desrt) <desrt@desrt.ca> minor
            change on menu from me.