GNOME Bugzilla – Bug 312046
Expanding directories in spatial view lacks keyboard navigation
Last modified: 2005-08-03 14:28:12 UTC
In the new 2.12 nautilus spatial mode, folders can be expanded in-place, without opening a new window. One would expect the following keybindings to work just like they do in the filesystem tree in browser-mode nautilus. The following keys should work: + expand the selected directory - collapse the selected directory * increase expand-level by one (expand all)
Thanks for your bug report!
Created attachment 49979 [details] [review] Proposed patch
I've tested this patch and it works fine in the standard case: - use the cursor keys to move to a folder - hit + - * (or whatever) and see the view expand/collapse However, in combination with type-ahead this patch doesn't do the Right Thing[tm].: - type the first few letters of a directory name - the directory will be selected - hit + - * - nothing happens
Created attachment 49980 [details] [review] Improved patch This improved patch will always allow the + - * / keys to be used for row expanding/collapsing. The side-effect of this is that these characters can no longer be used for type-ahead find. Luckily, + / * are not common characters in filename (I even think / is forbidden), but the - is quite regularly used. Should we special-case the minus sign? This should not be a user-interface problem, because folders are collapsed by default so that hitting - is pointless anyway.
Wouter: That was intentional, since there might also be a filename which contains +/-/*. I'm sure we can do better though. The problem is that if the cursor is on a folder, users might not expect that a +/*/- does an expansion instead of a completion.
Wouter: Good point. So we only have to care about '-'. I'd appreciate if you could come up with a patch which adds an if (view->details->type_select_state == NULL) clause in the '-' cases and explains in a comment why this is neccessary.
But then again: is it likely that these characters appear in filenames (especially at the start of a filename)? I think not and broken keyboard navigation seriously affects usability.
Ah. Seems like our comments crossed mid-air. I'll see what I can come up with, since I'm not a C coder.
Created attachment 49981 [details] [review] Improved patch Okay. I hope this improved patch addresses all mentioned concerns. + * / are always excluded from type-ahead, - is special-cased.
I've committed the last patch. Thanks for your efforts.
*** Bug 312464 has been marked as a duplicate of this bug. ***