After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311661 - GNOME_DOC_INIT needs version argument
GNOME_DOC_INIT needs version argument
Status: RESOLVED FIXED
Product: gnome-doc-utils
Classification: Deprecated
Component: build utils
CVS HEAD
Other Linux
: Normal normal
: ---
Assigned To: gnome-doc-utils maintainers
gnome-doc-utils maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-26 21:50 UTC by Christian Persch
Modified: 2005-07-27 17:41 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
proposed patch (1.20 KB, patch)
2005-07-26 22:08 UTC, Christian Persch 		none Details | Review
updated patch (1.19 KB, patch)
2005-07-26 22:39 UTC, Christian Persch 		none Details | Review
use pkg-config (744 bytes, patch)
2005-07-27 10:50 UTC, Christian Persch 		committed Details | Review

Description Christian Persch 2005-07-26 21:50:40 UTC 
When you compile from cvs using autogen, gnome-autogen.sh checks the minimum
required version of gdu. But when you compile a released tarball, there's no
autogen and no gdu version check; if the required gdu version isn't present
configure succeeds but make may fail.
Comment 1 Christian Persch 2005-07-26 22:08:49 UTC 
Created attachment 49807 [details] [review]
proposed patch

Adapted from the intltool code for the same purpose :)
Comment 2 Christian Persch 2005-07-26 22:12:35 UTC 
Instead of relying on that the 4th word of the output of gnome-doc-prepare
--version is the version, maybe we should add a --version-number or so which
just outputs the number.
Comment 3 Christian Persch 2005-07-26 22:39:39 UTC 
Created attachment 49808 [details] [review]
updated patch

Better patch; apply 0.3.2 as minimum-version if no argument given.
Comment 4 Shaun McCance 2005-07-27 06:49:53 UTC 
Couldn't we just check the version with 'pkg-config --modversion gnome-doc-utils'?
Comment 5 Christian Persch 2005-07-27 10:50:25 UTC 
Created attachment 49828 [details] [review]
use pkg-config

Yes we can. Much simpler this way :)
Comment 6 Christian Persch 2005-07-27 17:41:34 UTC 
2005-07-27  Christian Persch  <chpe@cvs.gnome.org>

        * gnome-doc-utils.m4:
        - Add minimum-version argument to GNOME_DOC_INIT, and check
        for the required gdu version. Minimum is 0.3.2 if not specified.
        Fixes bug #311661.