GNOME Bugzilla – Bug 311654
Font Preview window should close on Ctrl-W or Ctrl-Q
Last modified: 2012-06-04 15:47:41 UTC
The Font Preview window has no keyboard binding to close the window. Since this window has no keyboard interaction, there's no harm having both Ctrl-W and Ctrl-Q closing the window.
Thanks for your bug. According to the HIG the standard keybinding to close a window is Alt-F4. The other shortcut are used by the file menu.
http://developer.gnome.org/projects/gup/hig/2.0/input-keyboard.html#standard-shortcuts states: "If your application uses any of the standard functions listed in the following tables, use the recommended standard keyboard shortcut for that function.", followed by a list of standard shortcuts, group by their usual menu location. The HIG does not dictate that standard shortcuts should only be available to applications with a menu bar, so I think your reason to reject this usability improvement is invalid. After all, a font preview is like a "document" preview, so that Control-W should really do what users expect it to do (close the document). Besides, the Alt-F4 keybinding is the standard Window Manager keybinding to close a window, not the standard application keybinding, as can be seen in table 10.12. Applications should of course not use any standard keybindings in use by the window manager. Reopening this bug to allow for some more discussion.
Do you have any example of desktop applications with no file menu using ctrl-W for this?
Beagle's search dialog, for instance. Other applications without a file menu use Escape to close the window. Examples: - The standard "Find files" dialog - The "Services" dialog - The "Networking" dialog However, none of these applications are document viewers, whereas the font preview dialog is. Since the HIG does not explicitly mention this corner case, imho the logical conclusion would be: The font preview dialog _really_ is a document window, so the standard keyboard shortcuts should work, regardless of a menu bar being present. Oh, and while we're at it: the font preview dialog shuold also have a resize grippy on the lower right corner :) Thanks for discussing this issue!
beagle is not a part of the desktop. What do you call "find files"? The "Search files" from gnome-utils? It doesn't use ctrl-W/Q with GNOME 2.11.91 here. Same for network/services from gst. Imho it should stay coherent with other capplets. Ccing usability team to get their opinion on this.
I said: "Other applications without a file menu use Escape to close the window."
Oh, and since when is the font preview a capplet? We're talking about the preview application (try `gnome-open somefile.ttf`), not the font-prefs capplet!
right, that's an another option ... depends on how you define a capplet, that's a part of fontilus if use the sources for that
This problem applies to all of the preferences applets. The HIG should perhaps be changed to read: 'Ctrl-W -- Close the current document or window'
-> gnome-utils gnome-font-viewer has now moved to gnome-utils, reassigning.
(In reply to comment #9) > The HIG should perhaps be changed to read: > 'Ctrl-W -- Close the current document or window' We're not planning to update the current HIG any further now. But I certainly agree we need to take a better stab at resolving the whole window manager v. application v. close v. quit situation for the GNOME 3.x HIG. For this specific case, given that there's no explicit "just close the window" button or command in gnome-font-viewer (other than the one provided by the window manager), I'd say it's probably not unreasonable to expect Ctrl-Q. Ctrl-W is typically reserved for applications that allow you to open multiple windows or tabs. If you close the last window/tab, you also quit the application. 'Esc' is typically reserved for windows that have an explicit Close or Cancel button. (Some of us have argued that it should only work when there's a Cancel button, and indeed that's how gtk originally worked, but I've resigned myself to losing that battle...)
(In reply to comment #11) > For this specific case, given that there's no explicit "just close the window" > button or command in gnome-font-viewer (other than the one provided by the > window manager), I'd say it's probably not unreasonable to expect Ctrl-Q. Oops. "I'd say it's probably not unreasonable to expect Ctrl-Q to quit the application".
This is now fixed in git master.