The 'configure' file is generated from 'configure.ac' by autoconf, therefore
your patch doesn't help.  I don't have enough expertise to debug autoconf... :|

"with-gtkmozembed" is not a valid shell variable name which makes the fix seem
quite dubious.  What bug does the change fix?

The patch "helps" in the sense that demonstrates what is wrong with the
configure file taken from the gnome-python-extras-2.11.2 tarball currently
stored on the GNOME ftp site.

From  "configure --help":

                          ...
     --with-gtkmozembed=mozilla|firefox
                          package that provides libgtkmozembed

                          ...

Try this:
Run configure with:

           --with-gtkmozembed=firefox

What you will get is mozilla instead. The tests in the configure file fail
because of typos. The patch fixes the typos.

-Joseph

The patch you provided converts valid shell code to invalid shell code -- the
autoconf generated code uses "with_gtkmozembed" as a variable name instead of
"with-gtkmozembed" because "with-gtkmozembed" is not a valid shell variable
name.  Your patch is not fixing typos.

So your actual bug report is that passing "--with-gtkmozembed=firefox" doesn't
give the result you expect?

Consider a linux system with:

* mozilla-1.7.3 
installed under /usr

* firefox-1.0.5
installed under /opt/garnome

* PKG_CONFIG_PATH
set to: 
/opt/garnome/lib/pkgconfig:/usr/lib/pkgconfig:/opt/garnome/lib/python2.4/site-packages/gtk-2.0

We would like to build and install gnome-python-extras-2.11.2 under /opt/garnome
using the header files from firefox,ie,
 
     --with-gtkmozembed=firefox

The configuration file from taken from the gnome-python-extras-2.11.2 tarball
currently stored on the GNOME ftp site will *fail* to properly detect firefox.
Specifically,

                        ...
build_gtkmozembed=false

# Check whether --with-gtkmozembed or --without-gtkmozembed was given.
if test "${with_gtkmozembed+set}" = set; then
  withval="$with_gtkmozembed"
  mozpackage=$withval
else
  mozpackage=any
fi;

will fail to recognize that the configuration argument,

    --with-gtkmozembed=firefox 

was given. As a consquence of this failure, a test will be conducted for the
existence of mozilla-gtkmozembed.pc, which will be found under /usr/lib/pkgconfig.

If the patch I sent is applied to the configuration file, firefox will be
properly identified.

-Joseph

The option --with-gtkmozembed _does_ work at least on my system; I _did_ test
this when it was introduced in the 2.9.x series.  In any case,
gnome-python-extras looks for firefox before mozilla by default; so, if you want
firefox you  may not pass any --with-gtkmozembed argument.

I think there must be something wrong with your system.  Perhaps your shell?...

It does look like there is a possible bug in the configure logic.  In the case
where mozpackage != "any", the following is done:

case $mozpackage in
     firefox) mozpackage_required_version=firefox_required_version ;;
     mozilla) mozpackage_required_version=mozilla_required_version ;;
     *) AC_MSG_ERROR([--with-gtkmozembed argument must be either 'mozilla' or
'firefox'])
esac

PKG_CHECK_MODULES(GTKMOZEMBED, [mozilla-gtkmozembed >= $mozpackage_required_version,
                                gtk+-2.0            >= gtk_required_version],
  build_gtkmozembed=true,
  build_gtkmozembed=false)


So even if mozpackage=firefox, it will be looking for "mozilla-gtkmozembed"
instead of "firefox-gtkmozembed".  This is probably the bug Joseph ran into.

Ack! I guess I didn't test well enough :|

It should have been:
PKG_CHECK_MODULES(GTKMOZEMBED, [$mozpackage-gtkmozembed >=
$mozpackage_required_version,

That's what meant, anyway...

That works...  Good!!!

Gustavo, James... Thanks for the assistance.


Be well,

-Joseph