After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311637 - SJ segfaults because of trash: bookmark
SJ segfaults because of trash: bookmark
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: file-chooser
2.11.x
Other Linux
: Normal critical
: future
Assigned To: Alexander Larsson
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-07-26 17:55 UTC by Michael Monreal
Modified: 2005-08-23 11:10 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
a patch (1.18 KB, patch)
2005-08-19 18:23 UTC, Matthias Clasen
none Details | Review

Description Michael Monreal 2005-07-26 17:55:16 UTC
Distribution/Version: Ubuntu Breezy

This one is strange: If you add the trash to your nautilus/gtk bookmarks and
start sound-juicer while the file chooser is set to gnome-vfs mode, sound-juicer
will segfault without even showing the main window. Remove the bookmark or set
the file chooser to gtk+ and SJ works again.

I'm using SJ 2.11.90 and gnome-vfs 2.11.90... this could be a vfs bug but no
other application that uses file chooser with gnome-vfs (gedit, evince..)
suffers from this bug, so I filed it for SJ.
Comment 1 Ross Burton 2005-07-26 18:09:21 UTC
Can you provide a back trace?
Comment 2 Bastien Nocera 2005-07-26 19:16:48 UTC
That would be the FileChooserButton again.
Michael, could you try the small test-case at:
http://bugzilla.gnome.org/attachment.cgi?id=48875&action=view
with trash: added to your bookmarks?
Comment 3 Michael Monreal 2005-07-26 19:31:29 UTC
Yes, this seems to be the same: with trash: added, it dies instantly, after
removing the bookmark it works fine. Using strace, both produce something like

open("/home/nx/.gtk-bookmarks", O_RDONLY|O_LARGEFILE) = 26
fstat64(26, {st_mode=S_IFREG|0600, st_size=181, ...}) = 0
read(26, "trash:\nfile:///home/nx/Documents"..., 181) = 181
close(26)                               = 0
time(NULL)                              = 1122389951
time(NULL)                              = 1122389951
time(NULL)                              = 1122389951
--- SIGSEGV (Segmentation fault) @ 0 (0) ---
Comment 4 Bastien Nocera 2005-07-26 20:23:35 UTC
Could you explain how you added trash: to the bookmarks and attach your
~/.gtk-bookmarks to this bug?
Comment 5 Michael Monreal 2005-07-26 20:57:36 UTC
Doesn't matter how you add it, either open trash and "Bookmarks -> Add Bookmark"
or simply echo "trash:" >> .gtk-bookmarks

And there's really nothing fancy with the file, rm -rf .gtk-bookmarks and (after
logout) echo "trash:" > .gtk-bookmarks does the trick, too
Comment 6 Bastien Nocera 2005-07-26 21:05:08 UTC
Backtrace (very easily reproduceable with the testcase listed in comment #2, and
the instructions in comment #5):

  • #0 gtk_file_system_gnome_vfs_new
    from /usr/lib/gtk-2.0/2.4.0/filesystems/libgnome-vfs.so
  • #1 gtk_file_system_render_icon
    from /usr/lib/libgtk-x11-2.0.so.0
  • #2 gtk_file_chooser_button_get_type
    from /usr/lib/libgtk-x11-2.0.so.0
  • #3 gtk_file_chooser_button_get_type
    from /usr/lib/libgtk-x11-2.0.so.0
  • #4 g_object_newv
    from /usr/lib/libgobject-2.0.so.0
  • #5 g_object_new_valist
    from /usr/lib/libgobject-2.0.so.0
  • #6 g_object_new
    from /usr/lib/libgobject-2.0.so.0
  • #7 gtk_file_chooser_button_new_with_backend
    from /usr/lib/libgtk-x11-2.0.so.0
  • #8 main

Comment 7 Owen Taylor 2005-07-26 23:29:53 UTC
Bastien: can you install debuginfo packages and get a backtrace with
useful symbols?
Comment 8 Michael Monreal 2005-07-31 09:52:38 UTC
Two more apps that crash with the trash:/// bookmark:
- gnome-screenshot (crashes while starting)
- file-roller (crashes when opening extract dialog)
Comment 9 Matthias Clasen 2005-08-15 20:49:14 UTC
Bastien, are you still able to reproduce this ?
I have failed, the "trash:" url seems to be simply ignored for me.
Comment 10 Michael Monreal 2005-08-15 22:08:56 UTC
It's still happening here, with gtk 2.8.0 with latest sound-juicer, file-roller
and  gnome-screenshot
Comment 11 Matthias Clasen 2005-08-19 18:23:56 UTC
Created attachment 50994 [details] [review]
a patch
Comment 12 Matthias Clasen 2005-08-19 18:25:45 UTC
Seems federico was a bit sloppy when adding his desktop file hack. 
get_vfs_info() can return NULL.
Comment 13 Kjartan Maraas 2005-08-19 18:47:01 UTC
Commited. Thanks.
Comment 14 Michael Monreal 2005-08-23 11:10:08 UTC
After updating the libgnomeui package I have a strange problem with my trash...
I don't really think this is caused by the patch but I did not update any other
relevant packages I think and now, whenever I open the trash or navigate to
trash:/// it is empty although there are many deleted files in ~/.Trash

Did someone notice this, too?