After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311593 - fix timestamps
fix timestamps
Status: RESOLVED FIXED
Product: GStreamer
Classification: Platform
Component: gst-libav
git master
Other All
: High major
: 0.8.6
Assigned To: GStreamer Maintainers
GStreamer Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-26 14:01 UTC by Ronald Bultje
Modified: 2005-07-27 16:04 UTC
See Also:
GNOME target: ---
GNOME version: Unversioned Enhancement

Attachments
blabla (4.60 KB, patch)
2005-07-26 14:01 UTC, Ronald Bultje 		none Details | Review

Description Ronald Bultje 2005-07-26 14:01:05 UTC 
Since the latest CVS update to a new ffmpeg snapshot, I've removed
gst_ffmpeg_to/from_gst_timestamp() and replaced them by av_rescale_q(), which
may not have been a good idea after all, because we don't handle AV_NOPTS_VALUE
and GST_CLOCK_TIME_NONE correctly now... Attached patch fixes some timestamp
bugs in CVS of gst-ffmpeg. We should probably just re-institute those functions
and use them again...
Comment 1 Ronald Bultje 2005-07-26 14:01:21 UTC 
Created attachment 49779 [details] [review]
blabla
Comment 2 Brent Smith (smitten) 2005-07-26 23:05:39 UTC 
Marking new to get some attention b/c of the patch.
Comment 3 Ronald Bultje 2005-07-27 16:04:16 UTC 
2005-07-27  Ronald S. Bultje  <rbultje@ronald.bitfreak.net>

        * ext/ffmpeg/gstffmpegcodecmap.h:
        * ext/ffmpeg/gstffmpegdec.c: (gst_ffmpegdec_connect),
        (gst_ffmpegdec_frame), (gst_ffmpegdec_chain):
        * ext/ffmpeg/gstffmpegdemux.c: (gst_ffmpegdemux_loop):
        * ext/ffmpeg/gstffmpegenc.c: (gst_ffmpegenc_link),
        (gst_ffmpegenc_chain_video):
        * ext/ffmpeg/gstffmpegmux.c: (gst_ffmpegmux_loop):
          Use special functions for timestamp-conversion again, since we
          otherwise don't handle clocktimenone correctly (#311593).