GNOME Bugzilla – Bug 311381
[PATCH] Nautilus fix for displaying 'chits' for emblems property
Last modified: 2005-08-08 21:51:29 UTC
Go to that Backgrounds & Emblems dialog, now try dragging some "pattern" and you see that the PATTERN you drag shows up as DRAG icon (your mouse changes). Now do the same with "colors" and you see that the COLOR you drag shows up as DRAG icon. Now if you do the same with EMBLEMS you see nothing except the normal DRAG icon, you don't really know what emblem you want to drag. This small patch adds chits for emblems as well. Sorry, no illustration :)
Created attachment 49653 [details] [review] Adding some chits for emblems :)
can reproduce bug and there is a patch so status=new, priority=high
Any further comments on this ?
22:01:38 <interatom> it's a hack 22:02:12 <interatom> have you tried it? 22:02:41 <interatom> it looks arse, the method is ment to be used for patterns 22:02:56 <interatom> it scales the emblems in horrible ways
Sorry, the quotes I pasted were taken out of context. We were heavily discussing the patch and considered it not yet ready for inclusion. I'm trying to come up with something better... .
Created attachment 50302 [details] [review] Proposed patch I've also submitted this patch to the nautilus mailing list [1] for review. [1] http://mail.gnome.org/archives/nautilus-list/2005-August/msg00060.html
Short explanation: The problem used to be that we set the icon after the drag already started. That was not reliable.
2005-08-08 Martin Wehner <martin.wehner@gmail.com> * src/nautilus-property-browser.c: (nautilus_property_browser_class_init), (nautilus_property_browser_drag_begin), (element_clicked_callback): Fix emblem drag icon in "Emblems & Background" dialog. (#311381) Patch from Christian Neumair <chris@gnome-de.org>