After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 311063 - Search Folders: right-click -> "New Folder..." opens wrong dialog
Search Folders: right-click -> "New Folder..." opens wrong dialog
Status: RESOLVED INVALID
Product: evolution
Classification: Applications
Component: Mailer
2.2.x (obsolete)
Other All
: Normal normal
: ---
Assigned To: evolution-mail-maintainers
Evolution QA team
evolution[vfolders]
Depends on:
Blocks:
 
 
Reported: 2005-07-20 22:52 UTC by Carsten Guenther
Modified: 2005-09-28 20:29 UTC
See Also:
GNOME target: ---
GNOME version: ---


Attachments
Add rule dialog (46.69 KB, image/jpeg)
2005-08-29 20:50 UTC, Carsten Guenther
  Details
Proposed patch (2.40 KB, patch)
2005-09-06 22:22 UTC, Carsten Guenther
none Details | Review

Description Carsten Guenther 2005-07-20 22:52:46 UTC
Please describe the problem:
Right-clicking on "vFolders" and choosing "New Folder..." opens the dialog for
regular folders.

The menu item should read "New vFolder..." and should open the vFolder editor.

Steps to reproduce:


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 André Klapper 2005-07-21 12:08:21 UTC
i have definitely seen this request before in bugzilla, but cannot find it.
Comment 2 Carsten Guenther 2005-07-21 16:24:13 UTC
Yes, the bug is
    http://bugzilla.gnome.org/show_bug.cgi?id=254962

I didn't dup it because it was 1.5 and fixed.
Comment 3 Khasim Shaheed 2005-07-28 08:13:00 UTC
Confirming the bug, removing the probabledup keyword based on comment #2.
Comment 4 Calum Benson 2005-07-28 10:37:07 UTC
Apologies for any spam... cc'ing usability-maint on all Evolution usability
bugs. Filter on EVO-USABILITY-SPAM to ignore.
Comment 5 Not Zed 2005-08-05 08:08:08 UTC
This is correct and intentional.

If you create a vfolder from that window, then it pops up the vfolder editor;
but it needs to know the name and the parent first.
Comment 6 Carsten Guenther 2005-08-05 16:14:34 UTC
I don't understand the last comment. I am in the mail window. I right-click on
the "vFolders" entry. Choosing "New folder" from the menu opens the dialog for
regular folders, not the one for virtual folders. This is clearly wrong. Also
note that this is a regression since it was fixed in an earlier version (see Bug
254962).

Reopening.
Comment 7 Not Zed 2005-08-19 04:01:58 UTC
huh?  it always opens the vfolder editor to me.

did you select a vfolder parent?
Comment 8 Carsten Guenther 2005-08-19 18:54:09 UTC
Reopening.

Right-click "Search Folders" (Evo 2.3), select "New Folder". What I expect is
the dialog you get when choosing Edit->Search Folders. Instead you get the
dialog for regular folders. In order to get the desired dialog you have to enter
a folder name and select "Search Folders" again and click ok. This first dialog
is entirely unnecessary. Just open the "Search Folders" editor in the first place.

If it is still unclear I can do some screenshots :)
Comment 9 Carsten Guenther 2005-08-19 18:54:21 UTC
Reopening.

Right-click "Search Folders" (Evo 2.3), select "New Folder". What I expect is
the dialog you get when choosing Edit->Search Folders. Instead you get the
dialog for regular folders. In order to get the desired dialog you have to enter
a folder name and select "Search Folders" again and click ok. This first dialog
is entirely unnecessary. Just open the "Search Folders" editor in the first place.

If it is still unclear I can do some screenshots :)
Comment 10 Not Zed 2005-08-29 06:12:12 UTC
ok, so what i said when i closed the bug was a correct assessment.

new folder is supposed to open the new folder dialog, not the vfolder editor, so
you can give the folder an explicit name.

if it is still unclear ... i give up.
Comment 11 Carsten Guenther 2005-08-29 20:50:07 UTC
Created attachment 51524 [details]
Add rule dialog

Nope, there is a name field in the "Add rule" dialog as well. No need to bring
up the first dialog.
Comment 12 Carsten Guenther 2005-09-06 22:22:59 UTC
Created attachment 51890 [details] [review]
Proposed patch

Attached patch opens the right dialog without going through the folder-tree
selection dialog first.
Comment 13 parthasarathi susarla 2005-09-28 18:02:52 UTC
You would still need the New folder dialog to specify the parent folder. 
Comment 14 Carsten Guenther 2005-09-28 18:03:59 UTC
Since when do search folders have parent folders???
Comment 15 Carsten Guenther 2005-09-28 18:08:53 UTC
Oh boy, it really lets me create a search folder inside a real folder, which is
totally wrong in my opinion. Search folders should always be at the top-level.
Another reason for fixing this.
Comment 16 Carsten Guenther 2005-09-28 20:29:25 UTC
Ok, I will close this bug since it seems to be by design. There are issues with
this design though and I will open a new bug for this. Basically I think that
search folders should not be created inside other search folders or regular folders.