Created attachment 50556 [details] [review]
Patch file

This patch fixes this bug.  It also saves the maximized state, icon_view scroll
position, show toolbar, sidebar, timeline, tags, and dates.

Created attachment 50557 [details]
New File, Needed by Patch

The patch is complaining about being malformed.

Created attachment 50604 [details] [review]
Updated Patch

Sorry, I think I've finally figured out how to do this.  This patches/builds
against HEAD cleanly for me with:

patch -p0 < 310848.patch

from the directory that contains the "f-spot" dir.

*** Bug 311325 has been marked as a duplicate of this bug. ***

This looks pretty good, I'll try to get it in this week.

Bug 313789 is fixed by the above patch.

*** Bug 313789 has been marked as a duplicate of this bug. ***

Does this patch need any further work? If yes, what? I would really like to see
something like this in the next release...

I'm a little wary of overriding the wm position directly it seems like this
could get us into trouble if the root window geometry changes.  I'm not really
clear about what things we shouldsave ourselves an what things we should use
session management for.  Gabriel is some other program using this approach?

Hello Larry In my opinion,
remembering window related configurations such as window position, window size,
and window state is not important and AFAIK most applications doesn't have this
funtionallity,
what is important as i posted in Bug 313789 is remembering the status of tool
bars and dialogs, 
because many people may not use all the tool bars and dialogs always,
so they must hide tool bars or dialogs everytime after starting F-spot for
saving         screen realestate,
or someone may use F-Spot's Exif Data frequently, so he/she must always make
appear the Exif Data window every time after opening F-Spot,
so remembering the status of tool bars and dialogs is important,
by-the-way making F-Spot always open as maximized window would be usefull,

Larry,

You're probably right about the position -- it should be handled by the WM
(though amazingly HIG-compliant XChat and XMMS do it!).  I just need a WM that
does this for me (Metacity seems not to). :)

In terms of size and maximized?, Muine and Evolution (and probably others) seem
to  remember these settings.  I am not clear on why remembering the size of
one's app is better practice than remembering the position, though.  Naturally,
remembering the maximized state will mean Raghu gets his F-Spot opened maximized.

According to Havoc Pennington:

"Apps saving/restoring window positions across invocations of the app I
think is right (given current limitations of the specs anyway). You
should also be careful to save window states, in particular the
maximized flag. I would not set a window position if the user has never
opened that particular window though."

Patched in CVS. :)

*** Bug 320651 has been marked as a duplicate of this bug. ***