After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310596 - Infinite loop in http-neon-method.c
Infinite loop in http-neon-method.c
Status: RESOLVED FIXED
Product: gnome-vfs
Classification: Deprecated
Component: Module: http
unspecified
Other All
: Normal blocker
: ---
Assigned To: gnome-vfs maintainers
gnome-vfs maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-16 16:21 UTC by Jean-Yves Lefort
Modified: 2005-07-23 19:02 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Fix the infinite loop and s/aquire/acquire/ (1.16 KB, patch)
2005-07-16 16:21 UTC, Jean-Yves Lefort 		committed Details | Review

Description Jean-Yves Lefort 2005-07-16 16:21:03 UTC 
If HTTP authentication fails, GnomeVFS enters an infinite loop. Reasons:

  1) The neon method incorrectly interprets NE_AUTH and NE_PROXYAUTH as "please
retry".
  2) When received a NE_RETRY, the neon method does not use the existing
request, but creates a new one, thus clearing the neon internal retry state (so
NE_RETRY will be endlessly received again).

The attached patch fixes the issue, and while there, corrects a spelling mistake.
Comment 1 Jean-Yves Lefort 2005-07-16 16:21:39 UTC 
Created attachment 49289 [details] [review]
Fix the infinite loop and s/aquire/acquire/
Comment 2 Christian Kellner 2005-07-23 19:02:01 UTC 
Damn good catch! Thanks! Commit to cvs HEAD.