GNOME Bugzilla – Bug 310544
ability to make 'make check' advisory in tinderbox
Last modified: 2008-01-19 19:26:44 UTC
So... since so many things fail make check, I want to enable it, but at the same time, since failing make check does not prevent the building of dependent modules, I don't want it to block the build of later dependencies. Attached patch does that, but hardcodes it, so probably not acceptable upstream.
Created attachment 49268 [details] [review] makes check not really fail, but still displays output as red/etc.
This patch is a real hack. I'll definitely consider making this sort of thing less hacky when looking at the module type refactor though.
Created attachment 68798 [details] [review] Add a unittestfails parameter to jhbuildrc This patch adds a separate handling for unit tests failure in jhbuild. Autotools fire a TestsFailedError exception when there are errors running the tests. Then, the exception is checked in Package class when running, to decide if it has to fail or simply give an error message and continue. A new jhbuildrc property called unittestfails (defaulted to True to keep the current behavior) controls this.
jhbuild has a no poison mode that causes failures not to block the build of later dependencies. Specify -N or --no-poison from the command-line or set the following in .jhbuildrc: nopoison = True
2008-01-19 Frederic Peters <fpeters@0d.be> * doc/C/jhbuild.xml, jhbuild/config.py, jhbuild/defaults.jhbuildrc, jhbuild/modtypes/autotools.py, jhbuild/modtypes/waf.py, tests/mock.py, tests/tests.py: added a new makecheck_advisory option, to specify whether failures when running "make check" should be advisory only and not cause the module to fail; complete with documentation and unit tests. (closes: #310544)