After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310153 - Invalid URIs in gtk-bookmarks crash the file chooser
Invalid URIs in gtk-bookmarks crash the file chooser
Status: RESOLVED FIXED
Product: libgnomeui
Classification: Deprecated
Component: file-chooser
CVS HEAD
Other All
: High blocker
: ---
Assigned To: Federico Mena Quintero
Federico Mena Quintero
: 310140 314088 314090 447914 (view as bug list)
Depends on:
Blocks:
 
 
Reported: 2005-07-12 17:32 UTC by Luis Villa
Modified: 2007-07-15 16:17 UTC
See Also:
GNOME target: 2.14.x
GNOME version: 2.11/2.12

Attachments
Your wish is my command. (239 bytes, text/plain)
2005-07-12 18:46 UTC, Luis Villa 		Details

Description Luis Villa 2005-07-12 17:32:10 UTC 
Steps to reproduce:
1. hit 'printscreen'
2. boom



Stack trace:
Backtrace was generated from '/home/louie/jhbuilt/bin/gnome-screenshot'

Using host libthread_db library "/lib/tls/i686/cmov/libthread_db.so.1".
`system-supplied DSO at 0xffffe000' has disappeared; keeping its symbols.
[Thread debugging using libthread_db enabled]
[New Thread -1224440128 (LWP 5526)]
[New Thread -1228100688 (LWP 6256)]
[New Thread -1227809872 (LWP 6073)]
0xffffe410 in __kernel_vsyscall ()

+ Trace 61690

Thread 1 (Thread -1224440128 (LWP 5526))

  • #0 __kernel_vsyscall
  • #1 __waitpid_nocancel
    from /lib/tls/i686/cmov/libpthread.so.0
  • #2 libgnomeui_segv_handle
    at gnome-ui-init.c line 749
  • #3 <signal handler called>
  • #4 is_desktop_file
    at gtkfilesystemgnomevfs.c line 764
  • #5 gtk_file_system_gnome_vfs_render_icon
    at gtkfilesystemgnomevfs.c line 1763
  • #6 IA__gtk_file_system_render_icon
    at gtkfilesystem.c line 697
  • #7 model_add_bookmarks
    at gtkfilechooserbutton.c line 1422
  • #8 gtk_file_chooser_button_constructor
    at gtkfilechooserbutton.c line 667
  • #9 IA__g_object_newv
    at gobject.c line 949
  • #10 IA__g_object_new_valist
    at gobject.c line 1033
  • #11 IA__g_object_new
    at gobject.c line 830
  • #12 IA__gtk_file_chooser_button_new
    at gtkfilechooserbutton.c line 2223
  • #13 screenshot_dialog_new
    at screenshot-dialog.c line 213
  • #14 prepare_screenshot
    at gnome-panel-screenshot.c line 347
  • #15 main
    at gnome-panel-screenshot.c line 458
  • #0 __kernel_vsyscall 


Other information:
I assume that this is a libgnomeui or gtk problem, and not actually a screenshot
problem, but this is the only place I'm seeing it right now.
Comment 1 Federico Mena Quintero 2005-07-12 17:36:30 UTC 
Can you go to frame 5 and do "p (char *) path"?
Comment 2 Luis Villa 2005-07-12 17:41:33 UTC 
'x-nautilus-desktop:///'
Comment 3 Luis Villa 2005-07-12 17:42:22 UTC 
to be more clear:

(gdb) p (char *) path
$1 = 0x81ce268 "x-nautilus-desktop:///"
Comment 4 Luis Villa 2005-07-12 17:49:45 UTC 
I can get the same basic stack trace with the same value for path from
file-roller in some circumstances as well, so tentatively reassigning.
Comment 5 Luis Villa 2005-07-12 17:50:53 UTC 
*** Bug 310140 has been marked as a duplicate of this bug. ***
Comment 6 Federico Mena Quintero 2005-07-12 18:42:16 UTC 
Can you please attach your ~/.gtk-bookmarks?
Comment 7 Luis Villa 2005-07-12 18:46:17 UTC 
Created attachment 49046 [details]
Your wish is my command.
Comment 8 Federico Mena Quintero 2005-07-12 19:24:14 UTC 
I wonder how that "x-nautilus-desktop:" entry got in there.  I'll have a fix
shortly, but I may need to refactor some code to avoid making it a total hack. 
In the meantime and as a workaround, you can try removing that line from your
.gtk-bookmarks.
Comment 9 Luis Villa 2005-07-12 19:27:32 UTC 
No idea. I don't recall attempting to add a bookmark in forever. Perhaps a bug
in the new nautilus usage of the file?
Comment 10 Vincent Untz 2005-08-21 17:59:32 UTC 
*** Bug 314088 has been marked as a duplicate of this bug. ***
Comment 11 Vincent Untz 2005-08-21 18:00:58 UTC 
Any news on this?
This is a potential 2.12.0 showstopper.
Comment 12 Xavier Lacroze 2005-08-21 18:09:15 UTC 
I got the same problem. I did remove the faulty line in .gtk-bookmarks and
everything works fine. It also solved both issues with bugs 314088 and 314090.
No idea either how this entry got in .gtk-bookmarks
Comment 13 Xavier Lacroze 2005-08-21 18:10:08 UTC 
*** Bug 314090 has been marked as a duplicate of this bug. ***
Comment 14 Alexander Larsson 2005-09-02 10:17:54 UTC 
x-nautilus-desktop: really shouldn't appear in that list. I wonder how that
happened. However, other forms of invalid uris can surely appear there for
various reasons, and the code should handle that.
Comment 15 Kjartan Maraas 2006-01-01 22:22:00 UTC 
I guess we should try to improve this for 2.14.0 then
Comment 16 Elijah Newren 2006-01-11 23:51:19 UTC 
Don't know why luis set a target milestone of 'future' on this; I'm removing it.
Comment 17 Federico Mena Quintero 2006-01-12 01:52:34 UTC 
Retitling for clarity.

If a kind soul wants to take a shot at this, can you please do this:

1. Insert a "x-nautilus-desktop:///" bookmark in your ~/.gtk-bookmarks
2. Run gedit, open the file chooser

Please tell us if it still crashes.  If it does, then gtk_file_system_gnome_vfs_render_icon() needs a check right before the call to is_desktop_file().
Comment 18 Luis Villa 2006-01-12 01:59:00 UTC 
Seems to be robust now.

[And Elijah, I have no idea why I marked it future- must have been accidental.]
Comment 19 Teppo Turtiainen 2007-07-15 16:17:36 UTC 
*** Bug 447914 has been marked as a duplicate of this bug. ***