After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 310046 - smaller title frame in the side pane (browser windows)
smaller title frame in the side pane (browser windows)
Status: RESOLVED FIXED
Product: nautilus
Classification: Core
Component: general
2.11.x
Other All
: High enhancement
: ---
Assigned To: Nautilus Maintainers
Nautilus Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-11 18:44 UTC by Vincent Noel
Modified: 2007-12-30 15:28 UTC
See Also:
GNOME target: ---
GNOME version: 2.11/2.12


Attachments
before (left) and after (right) comparison (10.42 KB, image/png)
2005-07-11 18:45 UTC, Vincent Noel
Details

Description Vincent Noel 2005-07-11 18:44:26 UTC
Browser windows look nicer when a smaller version of the close icon is used.
Comment 1 Vincent Noel 2005-07-11 18:45:09 UTC
Created attachment 48973 [details]
before (left) and after (right) comparison
Comment 2 Vincent Noel 2005-07-11 18:46:38 UTC
Of course, this is very subjective :-) But the title in the side pane has always
looked akward to me, and this one-line change looks better to me :

Index: src/nautilus-side-pane.c
===================================================================
RCS file: /cvs/gnome/nautilus/src/nautilus-side-pane.c,v
retrieving revision 1.9
diff -u -r1.9 nautilus-side-pane.c
--- src/nautilus-side-pane.c    28 Jun 2005 12:54:45 -0000      1.9
+++ src/nautilus-side-pane.c    11 Jul 2005 18:45:21 -0000
@@ -379,7 +379,7 @@
        gtk_widget_show (close_button);

        image = gtk_image_new_from_stock (GTK_STOCK_CLOSE,
-                                         GTK_ICON_SIZE_SMALL_TOOLBAR);
+                                         GTK_ICON_SIZE_MENU);
        gtk_widget_show (image);

        gtk_container_add (GTK_CONTAINER (close_button), image);
Comment 3 Christian Neumair 2005-07-12 20:16:13 UTC
Maybe you could send this patch to the nautilus mailing list [1] for review?

[1] http://mail.gnome.org/mailman/listinfo/nautilus-list
Comment 4 Christian Neumair 2005-07-20 10:38:00 UTC
Vincent?
Comment 5 Vincent Noel 2005-07-20 13:22:15 UTC
I sent it to the nautilus mailing list, however I'm afraid it's a little late to
change the UI...
Comment 6 Cosimo Cecchi 2007-12-30 15:28:35 UTC
Reading the code, Vincent patch seems to be committed in current SVN trunk, so I'm closing this bug as FIXED.