After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309967 - Memory leak in /gimp/plug-ins/common/gauss.c ?
Memory leak in /gimp/plug-ins/common/gauss.c ?
Status: RESOLVED FIXED
Product: GIMP
Classification: Other
Component: Plugins
git master
Other All
: Normal trivial
: 2.4
Assigned To: GIMP Bugs
GIMP Bugs
Depends on:
Blocks:
 
 
Reported: 2005-07-10 19:26 UTC by Bernd Beuster
Modified: 2005-07-11 15:39 UTC
See Also:
GNOME target: ---
GNOME version: ---



Description Bernd Beuster 2005-07-10 19:26:02 UTC
Please describe the problem:
Can't find g_free(sum) and g_free(curve).  Is this a possible memory leak?


Steps to reproduce:
Inspecting CVS source http://cvs.gnome.org/viewcvs/gimp/plug-ins/common/gauss.c?
rev=1.23&view=markup


Actual results:


Expected results:


Does this happen every time?


Other information:
Comment 1 Sven Neumann 2005-07-11 10:42:57 UTC
Memory leaks in plug-ins aren't really bothersome since the plug-in runs in a
separate process. But of course it would be nicer if the plug-in didn't leak.
This does indeed look like a memleak to me. If you or someone else wants to
attempt a fix, patches are welcome.
Comment 2 Sven Neumann 2005-07-11 11:15:09 UTC
Had a look at it myself. Fixed in CVS HEAD; probably not worth backporting to 2.2:

2005-07-11  Sven Neumann  <sven@gimp.org>

	* plug-ins/common/gauss.c: plugged memory leaks (bug #309967).
	Invalidate the preview when the algorithm is changed; default to
	RLE since it appears to be faster for the cases I tried.
Comment 3 weskaggs 2005-07-11 15:39:07 UTC
Just a followup note on the factors that affect speed:  a look at the algorithms
indicates that RLE gains an advantage when there are lots of places where
neighborig pixels have the same color; IIR gains an advantage when the blur
radius is large.  But the differences should not be huge in either case.