After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309853 - Places menu "computer" entry doesn't honor user setting
Places menu "computer" entry doesn't honor user setting
Status: RESOLVED FIXED
Product: gnome-panel
Classification: Other
Component: general
2.10.x
Other All
: Normal minor
: ---
Assigned To: Panel Maintainers
Panel Maintainers
Depends on:
Blocks:
 
 
Reported: 2005-07-08 22:45 UTC by Mike Miller
Modified: 2005-09-15 20:48 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Patch that should fix that (1.01 KB, patch)
2005-07-12 01:41 UTC, Marco Cabizza 		none Details | Review
WORKING patch, I bet (2.89 KB, patch)
2005-07-12 02:10 UTC, Marco Cabizza 		rejected Details | Review

Description Mike Miller 2005-07-08 22:45:38 UTC 
The "computer" icon on the desktop allows you to rename it to something more
descriptive.  This setting is kept in the gconf key:
/apps/nautilus/desktop/computer_icon_name

However this setting doesnt affect the Places menu, which continues to read,
"computer" no matter what it has been renamed to.

These labels should match.
Comment 1 Marco Cabizza 2005-07-12 01:41:59 UTC 
Created attachment 48994 [details] [review]
Patch that should fix that

The patch is badly done... but the code itself works quite fine here and, of
course, fixes that problem. Testing is really appreciated. It's the first CVS
patch i submit, so if anybody can suggest me some guidelines about patching
files, I would be pleased.
Marco
Comment 2 Marco Cabizza 2005-07-12 02:10:56 UTC 
Created attachment 48995 [details] [review]
WORKING patch, I bet

OK, this should patch fine, it does, I tried, and it works fine. This contains:


1) A fix for #309853
2) A GUI implementation for "killall gnome-panel" as a context menu entry
called "Refresh Panel" (useful when having broken applets, you can't imagine
how much I used this one during this last hour, so you may think about
including it, you decide!)
3) The it.po patch for "Refresh Panel", of course

Sorry for having posted 2) and 3) here but I have found them useful, and I
thought that if you didn't want them, they could be easily removed from the
diff.

Marco
Comment 3 Vincent Untz 2005-09-15 20:48:19 UTC 
Your patch is not okay since it does not correctly use gconf.
I've committed a fix for this.

(also, "refresh panel" will not be accepted ;-))