After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309684 - Contact text entry leaks threads
Contact text entry leaks threads
Status: RESOLVED FIXED
Product: evolution-data-server
Classification: Platform
Component: Contacts
1.2.x (obsolete)
Other Linux
: Normal normal
: ---
Assigned To: evolution-addressbook-maintainers
Evolution QA team
Depends on:
Blocks:
 
 
Reported: 2005-07-07 07:44 UTC by Ross Burton
Modified: 2005-07-08 05:58 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
Stop and unref book views which complete normally (807 bytes, patch)
2005-07-07 08:39 UTC, Ross Burton 		none Details | Review
Improved patch (739 bytes, patch)
2005-07-07 10:29 UTC, Ross Burton 		none Details | Review

Description Ross Burton 2005-07-07 07:44:56 UTC 
The contact entry used in the email Compose window doens't stop the underlying
BookView, so the thread state is never freed.  On a typical system this is a 8M
allocation for the stack, so for every mail composed 8M is allocated and never
released.

This can be checked by using pmap:

$ pmap -x [e-d-s pid] | grep rwx |

All items which are 8192K and [anon] are thread stacks.  Searching the
addressbook will not result in this total changing as the thread is correctly
destroyed, but typing into the To: field in Evo will add entries.
Comment 1 Ross Burton 2005-07-07 07:51:35 UTC 
Note: I believe this is due to g_thread_join() not being called in the view on
the server, which is typically due to the view not being stopped, either
explictly or by being unrefed.
Comment 2 Ross Burton 2005-07-07 08:39:43 UTC 
Created attachment 48768 [details] [review]
Stop and unref book views which complete normally

When a book view is allowed to run to completion, it isn't unreffed.  This
patch calls the internal stop method (for symmetry) and the unrefs the
completed bookview.

There appears to be more problems like this though, my EDS currently appears to
have 32 threads at the moment, although only three are running.
Comment 3 Ross Burton 2005-07-07 10:29:03 UTC 
Created attachment 48772 [details] [review]
Improved patch
Comment 4 Sushma Rai 2005-07-08 05:58:52 UTC 
Thanks, Committed this fix to CVS head.
Closing the bug.