GNOME Bugzilla – Bug 309629
picture is small, off-center
Last modified: 2008-05-08 19:02:42 UTC
Why is my picture small and off-center in this huge button? It should fill the whole thing. Minor, but ugly.
I just commited a change that makes the image to be center horizontally, to center it vertically and have the visual indication when using DnD is more difficult due to the GtkFrame that the widget is using.
Diego, it's still far smaller then the button. I think the right way to do this would be to specifiy the image size for e-image-chooser
The issue was discussed at https://launchpad.net/distros/ubuntu/+source/control-center/+bug/31884 as well. There with control-center 2.13.91.
I'm using gnome-control-center 1:2.16.0-0ubuntu1 and have a similar problem, but it doesn't sound like it is the same as ubuntu bug 31884. Instead of trying to explain the problem, you should look at the screenshots. https://launchpad.net/distros/ubuntu/+source/control-center/+bug/59236 Screenshots: http://librarian.launchpad.net/4158030/Screenshot-About%20Darren%20Hinderer.png http://librarian.launchpad.net/4158082/shouldlooklikethis.png
*** Bug 531330 has been marked as a duplicate of this bug. ***
I'd like to take a stab at this if anyone can point me in the right direction.
I'd start looking in e-image-chooser.c. That file was apparently copied from evolution (or e-d-s?) once upon a time, so comparing the about-me version with the original might already give you a few hints.
Created attachment 110541 [details] [review] Proposed patch
Created attachment 110542 [details] Screenshot of previous patch
Looks good apart from a few stylistic issues. Thanks! 2008-05-08 Jens Granseuer <jensgr@gmx.net> Patch by: Ben LeMasurier <ben.lemasurier@gmail.com> * e-image-chooser.c: (e_image_chooser_init), (set_image_from_data), (image_drag_motion_cb), (image_drag_drop_cb): fix scaling the image on the user photo button (bug #309629)