After an evaluation, GNOME has moved from Bugzilla to GitLab. Learn more about GitLab.
No new issues can be reported in GNOME Bugzilla anymore.
To report an issue in a GNOME project, go to GNOME GitLab.
Do not go to GNOME Gitlab for: Bluefish, Doxygen, GnuCash, GStreamer, java-gnome, LDTP, NetworkManager, Tomboy.
Bug 309464 - gtkfilesystemwin32.c: DeleteObject may not be called in extract_icon.
gtkfilesystemwin32.c: DeleteObject may not be called in extract_icon.
Status: RESOLVED FIXED
Product: gtk+
Classification: Platform
Component: Backend: Win32
2.7.x
Other All
: Normal minor
: ---
Assigned To: gtk-win32 maintainers
gtk-bugs
Depends on:
Blocks:
 
 
Reported: 2005-07-04 18:10 UTC by Kazuki Iwamoto
Modified: 2005-07-06 15:31 UTC
See Also:
GNOME target: ---
GNOME version: ---

Attachments
DeleteObject are moved to the correct position. (730 bytes, patch)
2005-07-04 18:14 UTC, Kazuki Iwamoto 		none Details | Review

Description Kazuki Iwamoto 2005-07-04 18:10:39 UTC 
Please describe the problem:
DeleteObject may not be called for objects which should be deleted in extract_icon.
ii.hbmColor and ii.hbmMask are deleted when no_alpha is true.
Otherwise, those are not deleted.

Steps to reproduce:
1. Put an icon which has alpha channel in any folder.
2. Display its folder by gtkfilechooser.

Actual results:
ii.hbmColor and ii.hbmMask are not deleted.

Expected results:
ii.hbmColor and ii.hbmMask should be deleted by DeleteObject.

Does this happen every time?
In extract_icon, ii.hbmColor has alpha cannel.

Other information:
Comment 1 Kazuki Iwamoto 2005-07-04 18:14:34 UTC 
Created attachment 48638 [details] [review]
DeleteObject are moved to the correct position.
Comment 2 Tor Lillqvist 2005-07-06 15:31:24 UTC 
Fixed as part of implementing gdk_cursor_get_image(), the code in
gdk_win32_icon_to_pixbuf_libgtk_only() deletes the hbmColor and hbmMask bitmaps.